Show more relevant events in 'Events at hand' #6049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
force-pushed
the
events-at-hand
branch
2 times, most recently
from
5c42148 to
39cdd84
Compare
Member
|
Previously we sorted from old to new, now it's new to old. I'm fine either way but maybe we should be consistent and use the same order for "my unlisted events"... |
Currently, we show up to 10 events whose end date is at most 1 week in the past sorted by start_date. If a user has more than 10 events which ended in the last week, no future events are shown. This change sorts the events based on the absolute difference with respect to the current date so that both past and future events are shown more equally.
tomasr8
force-pushed
the
events-at-hand
branch
from
39cdd84 to
33b4daa
Compare
Member
Author
Yep I missed that somehow, should be fixed |
ThiefMaster
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we show up to 10 events whose end date is at most 1 week in the past sorted by start_date. If a user has more than 10 events which ended in the last week, no future events are shown.
This change sorts the events based on the absolute difference with respect to the current date so that both past and future events are shown more equally.