Improve i18n support for renderRecurrenceWeekdays()
#6000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GovernmentPlates
changed the title
renderRecurrenceWeekdays() function
GovernmentPlates
force-pushed
the
Improve-Weekdays-i18n
branch
2 times, most recently
from
57e9df8 to
94f4f4c
Compare
GovernmentPlates
changed the title
renderRecurrenceWeekdays() functionrenderRecurrenceWeekdays()
GovernmentPlates
force-pushed
the
Improve-Weekdays-i18n
branch
from
94f4f4c to
8632304
Compare
ThiefMaster
reviewed
Oct 24, 2023
tomasr8
reviewed
Oct 24, 2023
GovernmentPlates
force-pushed
the
Improve-Weekdays-i18n
branch
3 times, most recently
from
510a1bc to
41adcc8
Compare
tomasr8
reviewed
Oct 25, 2023
GovernmentPlates
force-pushed
the
Improve-Weekdays-i18n
branch
from
41adcc8 to
fa593df
Compare
tomasr8
reviewed
Oct 25, 2023
tomasr8
approved these changes
Oct 25, 2023
GovernmentPlates
force-pushed
the
Improve-Weekdays-i18n
branch
2 times, most recently
from
b01ad88 to
3bbea42
Compare
ThiefMaster
force-pushed
the
Improve-Weekdays-i18n
branch
from
3bbea42 to
6adcf9f
Compare
ThiefMaster
force-pushed
the
Improve-Weekdays-i18n
branch
from
063480e to
d15a845
Compare
ThiefMaster
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an i18n improvement for the
renderRecurrenceWeekdays()function (part of #5829) which uses the Intl.ListFormat API instead.