Skip to content

Conversation

@GovernmentPlates
Copy link
Member

@GovernmentPlates GovernmentPlates commented Oct 23, 2023

This PR addresses an edge-case found in #5829 where editing a recurring 'by weekday' or 'by monthly' booking that was already in-progress would raise an error when either the booking recurrence interval was modified from weekly <-> monthly.

UI Preview:
image

@GovernmentPlates GovernmentPlates marked this pull request as draft October 23, 2023 14:02
@GovernmentPlates GovernmentPlates force-pushed the Disallow-Recurring-Booking-Edits branch 2 times, most recently from fc9f2bd to 7dda9bd Compare October 23, 2023 20:50
@GovernmentPlates GovernmentPlates marked this pull request as ready for review October 24, 2023 07:31
@GovernmentPlates GovernmentPlates changed the title Disable editing recurring bookings that are marked as in-progress Disable editing the repeat frequency of existing recurring bookings Oct 24, 2023
@GovernmentPlates GovernmentPlates force-pushed the Disallow-Recurring-Booking-Edits branch from 50004b9 to 5c057b5 Compare October 27, 2023 08:36
@ThiefMaster ThiefMaster force-pushed the Disallow-Recurring-Booking-Edits branch from 5c057b5 to c453c10 Compare October 30, 2023 12:49
@ThiefMaster ThiefMaster enabled auto-merge (squash) October 30, 2023 12:51
@ThiefMaster ThiefMaster added this to the v3.3 milestone Oct 30, 2023
@ThiefMaster ThiefMaster merged commit e7aa7b6 into indico:master Oct 30, 2023
@ThiefMaster ThiefMaster deleted the Disallow-Recurring-Booking-Edits branch October 30, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants