Add auto-linker for patterns in notes #5998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Oct 23, 2023
Member
|
A cool feature (but probably more nice-to-have) would be a "test area" below the management UI where you can write markdown or HTML and see the output :) |
pferreir
force-pushed
the
add-autolinker
branch
from
5448e46 to
1d3e449
Compare
Member
Author
Will you believe I did think of that? I kind of dismissed it as "nice to have", but maybe it's actually not that hard to do it, at least as far as Markdown is concerned. I'll see what I can do. |
pferreir
force-pushed
the
add-autolinker
branch
from
1d3e449 to
2cb483f
Compare
Member
Author
|
Added a "test-drive" component: 
|
pferreir
force-pushed
the
add-autolinker
branch
4 times, most recently
from
a73b957 to
78d7153
Compare
ThiefMaster
reviewed
Oct 27, 2023
pferreir
force-pushed
the
add-autolinker
branch
from
158cdcf to
6b395ba
Compare
pferreir
force-pushed
the
add-autolinker
branch
2 times, most recently
from
251c4d0 to
1cb2363
Compare
ThiefMaster
reviewed
Oct 31, 2023
indico/modules/events/client/js/components/AutoLinkerConfig.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/client/js/components/AutoLinkerConfig.jsx
Outdated
Show resolved
Hide resolved
pferreir
force-pushed
the
add-autolinker
branch
from
1cb2363 to
ce379c3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <List divided relaxed> | ||
| {rules.map(({regex, url}, n) => { | ||
| const encodedURI = encodeURIComponent(url.replace(/\{(\d+)\}/g, '\\$1')); | ||
| const encodedRegex = encodeURIComponent(regex.replace(/"/g, '\\"')); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
ThiefMaster
reviewed
Oct 31, 2023
pferreir
force-pushed
the
add-autolinker
branch
from
ce379c3 to
9eb93e7
Compare
ThiefMaster
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a long-awaited (at least by me!) feature, which automatically adds links around specific text patterns. It works for notes, both in markdown (w/ preview) and TinyMCE (no preview, unfortunately).
The only problem I noticed so far is that if we use a super-generic regex, e.g.
(\d+), the markdown parser gets stuck in an infinite loop. I'm convinced this is probably a bug in themarkdownpackage, but given this is an admin-only feature, I reckon the risk of abuse/accidents is minimal.