Skip to content

Conversation

@openprojects
Copy link
Contributor

Some login page UI improvements:

  • make login logo customisable
  • add logo to external providers login button
  • improve readability: bigger buttons
  • move "Create local account" under local account login
  • center footer

Screenshot 2023-09-20 at 10 35 02

@tomasr8
Copy link
Member

tomasr8 commented Sep 22, 2023

Since we're updating the login page, let's make the or connect with text darker. Firefox complains that it doesn't meet standards for accessible text - the color needs to be at least #737373.`

@openprojects
Copy link
Contributor Author

Since we're updating the login page, let's make the or connect with text darker. Firefox complains that it doesn't meet standards for accessible text - the color needs to be at least #737373.`

Do you mean changing the "titled-rule" class for every instance or just for the login page?

@tomasr8
Copy link
Member

tomasr8 commented Sep 22, 2023

I'd modify the titled-rule class so that it applies everywhere, not just the login page

@openprojects openprojects force-pushed the Login-page-UI-improvements branch from 72467dd to a574a3a Compare September 25, 2023 07:51
@ThiefMaster
Copy link
Member

I don't like that fact that the footer is now also vertically centered and no longer at the bottom of the screen.
I think your change was just meant to center it horizontally (which is probably fine - would need to see it though), but vertically centering it as well really doesn't look great...

@openprojects
Copy link
Contributor Author

I don't like that fact that the footer is now also vertically centered and no longer at the bottom of the screen. I think your change was just meant to center it horizontally (which is probably fine - would need to see it though), but vertically centering it as well really doesn't look great...

YES, the idea is just to center it horizontally, no problems to keep it vertically attached to the bottom of the screen.

@openprojects openprojects force-pushed the Login-page-UI-improvements branch from a027805 to c0a7358 Compare September 26, 2023 09:35
@openprojects
Copy link
Contributor Author

I don't like that fact that the footer is now also vertically centered and no longer at the bottom of the screen. I think your change was just meant to center it horizontally (which is probably fine - would need to see it though), but vertically centering it as well really doesn't look great...

YES, the idea is just to center it horizontally, no problems to keep it vertically attached to the bottom of the screen.

Should be better now.

@ThiefMaster
Copy link
Member

Not really... it's fine vertically now, but worse horizontally

image

@openprojects
Copy link
Contributor Author

Not really... it's fine vertically now, but worse horizontally

image

You are right.... NOW should be better :)

@ThiefMaster ThiefMaster force-pushed the Login-page-UI-improvements branch from 4a46e10 to 0d0fbfe Compare September 28, 2023 08:22
@ThiefMaster ThiefMaster force-pushed the Login-page-UI-improvements branch from 95109e3 to 7a03e4a Compare September 28, 2023 08:25
@ThiefMaster ThiefMaster added this to the v3.3 milestone Sep 28, 2023
@ThiefMaster ThiefMaster merged commit 0e7122c into indico:master Sep 28, 2023
openprojects added a commit to UNOG-Indico/indico-core that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants