-
Notifications
You must be signed in to change notification settings - Fork 510
Support forcing users to accept ToS and privacy policy #5925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
fwiw after some renaming I just noticed that it doesn't quite fit under privacy policy any more. I don't think it fits in any of the others (though maybe the Terms one), and a new section could be overkill. I'll leave it to your judgement where it fits best. |
e64a29d to
528859b
Compare
528859b to
72aefd3
Compare
|
@ThiefMaster it might not be quite perfect yet, but this is ready for a new round of reviews. See context in #5923 |
72aefd3 to
7333451
Compare
7333451 to
d8064d8
Compare
0e569da to
81a733a
Compare
81a733a to
0a74480
Compare
|
@ThiefMaster I've hit a snag on this while debugging something else and could use your advice: This approach seems to fail for urls that have Is there a way to do this interception later, or a better way to check for the user at this stage? |
|
Do you mean the time when |
Yeah, this works much better. It feels a little unclean, but I'll leave that to the review if it works out good enough :) @ThiefMaster also friendly reminder for this comment: #5925 (comment) |
0a74480 to
add6399
Compare
add6399 to
2afd8ab
Compare
2afd8ab to
0e44879
Compare
|
All current review comments taken care of :) |
Also more consistent with another template that builds links
eee33fc to
6c8e3cb
Compare
- use similar endpoint whitelist like in case of bad passwords - exclude non-GET requests altogether (those might break things when people are editing something and want to save)
Also improve formatting
ThiefMaster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice pr :)
Fixes #5923 .