Invalidate password reset links on password change #5878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SegiNyn
pushed a commit
to UNOG-Indico/indico-core
that referenced
this pull request
Aug 2, 2023
OmeGak
pushed a commit
to UNOG-Indico/indico-core
that referenced
this pull request
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by the UNOG guys, and even though the links are only valid for 1 hour (ie the risk of a stale link being abused is basically zero), it's still better to invalidate them as soon as the password has been changed.
Considering how rare password resets are, and how short-lived those links are, I didn't add any special handling of links created before this change. People getting an error would probably just request a new link anyway.