-
Notifications
You must be signed in to change notification settings - Fork 510
Refactor EditingRevision #5674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ThiefMaster
merged 20 commits into
indico:master
from
duartegalvao:the-great-timeline-refactoring
Aug 16, 2023
Merged
Refactor EditingRevision #5674
ThiefMaster
merged 20 commits into
indico:master
from
duartegalvao:the-great-timeline-refactoring
Aug 16, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0bc475 to
02aacbf
Compare
57e88c5 to
84cde06
Compare
56068bc to
c3f9999
Compare
145df7d to
aacf605
Compare
tomasr8
reviewed
Aug 2, 2023
indico/modules/events/editing/client/js/editing/timeline/TimelineItem.jsx
Outdated
Show resolved
Hide resolved
aacf605 to
84f758f
Compare
84f758f to
af85efd
Compare
tomasr8
reviewed
Aug 3, 2023
tomasr8
reviewed
Aug 3, 2023
6babf67 to
94efd6d
Compare
duartegalvao
commented
Aug 10, 2023
indico/migrations/versions/20230810_1300_0af8f63aa603_refactor_editing_revisions.py
Outdated
Show resolved
Hide resolved
355ed9e to
9d4341d
Compare
9d4341d to
b974f3a
Compare
ThiefMaster
reviewed
Aug 15, 2023
ThiefMaster
reviewed
Aug 15, 2023
indico/migrations/versions/20230810_1300_0af8f63aa603_refactor_editing_revisions.py
Outdated
Show resolved
Hide resolved
ThiefMaster
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at refactoring the
EditingRevisionto make it match better with the way it's presented in the UI, as well as to simplify a lot of the processes in the backend.Main changes:
initial_stateandfinal_stateare replaced by atype. Each type corresponds to an editing action, either by the submitter, editor, or the system:new- a submitter revision that hasn't been exposed to editors yetready_for_review- a submitter revision that can be reviewed by editorsneeds_submitter_confirmation- an editor revision with changes the submitter needs to approve or rejectchanges_acceptance- a submitter revision that accepts the changes made by the editorchanges_rejection- a submitter revision that rejects the changes made by the editorneeds_submitter_changes- an editor revision that requires the submitter to submit a new revisionacceptance- an editor revision that accepts the editablerejection- an editor revision that rejects the editablereplacement- a system revision that replaces the current revisionreset- a system revision that resets the state of the editable to "ready for review"submitterandeditorare replaced by just oneusercreated_dtandreviewed_dtare replaced by just onecreated_dtis_undoneboolean column, which replaces theundonefinal state and theEditingRevisionComment .undone_judgment.resettype) correspond to a top-level item/box in the editing timeline.