Skip to content

Conversation

@duartegalvao
Copy link
Member

@duartegalvao duartegalvao commented Feb 14, 2023

This PR is an attempt at refactoring the EditingRevision to make it match better with the way it's presented in the UI, as well as to simplify a lot of the processes in the backend.

Main changes:

  • initial_state and final_state are replaced by a type. Each type corresponds to an editing action, either by the submitter, editor, or the system:
    • new - a submitter revision that hasn't been exposed to editors yet
    • ready_for_review - a submitter revision that can be reviewed by editors
    • needs_submitter_confirmation - an editor revision with changes the submitter needs to approve or reject
    • changes_acceptance - a submitter revision that accepts the changes made by the editor
    • changes_rejection - a submitter revision that rejects the changes made by the editor
    • needs_submitter_changes - an editor revision that requires the submitter to submit a new revision
    • acceptance - an editor revision that accepts the editable
    • rejection - an editor revision that rejects the editable
    • replacement - a system revision that replaces the current revision
    • reset - a system revision that resets the state of the editable to "ready for review"
  • submitter and editor are replaced by just one user
  • created_dt and reviewed_dt are replaced by just one created_dt
  • Revisions no longer require having files. A revision now corresponds to an editing action, with or without files.
  • New is_undone boolean column, which replaces the undone final state and the EditingRevisionComment .undone_judgment.
  • All editing revisions (except for reset type) correspond to a top-level item/box in the editing timeline.

@ThiefMaster ThiefMaster added this to the v3.3 milestone Feb 14, 2023
@duartegalvao duartegalvao force-pushed the the-great-timeline-refactoring branch 2 times, most recently from b0bc475 to 02aacbf Compare May 23, 2023 09:06
@duartegalvao duartegalvao force-pushed the the-great-timeline-refactoring branch 5 times, most recently from 57e88c5 to 84cde06 Compare July 19, 2023 14:52
@duartegalvao duartegalvao force-pushed the the-great-timeline-refactoring branch 9 times, most recently from 56068bc to c3f9999 Compare July 27, 2023 15:30
@duartegalvao duartegalvao force-pushed the the-great-timeline-refactoring branch 5 times, most recently from 145df7d to aacf605 Compare August 2, 2023 09:04
@duartegalvao duartegalvao force-pushed the the-great-timeline-refactoring branch 2 times, most recently from 6babf67 to 94efd6d Compare August 3, 2023 15:04
@duartegalvao duartegalvao force-pushed the the-great-timeline-refactoring branch from 355ed9e to 9d4341d Compare August 14, 2023 15:17
@ThiefMaster ThiefMaster force-pushed the the-great-timeline-refactoring branch from 9d4341d to b974f3a Compare August 15, 2023 08:23
@ThiefMaster ThiefMaster enabled auto-merge (squash) August 16, 2023 09:53
@ThiefMaster ThiefMaster merged commit e523887 into indico:master Aug 16, 2023
@ThiefMaster ThiefMaster deleted the the-great-timeline-refactoring branch August 16, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done 🚀

Development

Successfully merging this pull request may close these issues.

3 participants