Add receipt generation #5123
Merged
Add receipt generation #5123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Oct 12, 2021
indico/migrations/versions/20211001_1530_252d61f890a0_add_receipt_data_structures.py
Outdated
Show resolved
Hide resolved
pferreir
force-pushed
the
add-receipt-templates
branch
2 times, most recently
from
75c1791 to
6003304
Compare
ThiefMaster
reviewed
Oct 14, 2021
| 'not exist in the `error_messages` dictionary.' | ||
| ).format(class_name=class_name, key=key) | ||
| raise AssertionError(message) from error | ||
| if isinstance(msg, (str, bytes, _LazyString)): |
Member
There was a problem hiding this comment.
I wonder if marshmallow would accept a PR that duck-types this instead of using a type check...
Member
Author
There was a problem hiding this comment.
Yeah, that might be an option.
indico/modules/events/receipts/client/js/templates/TemplatePane.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/receipts/client/js/templates/TemplateManagement.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/receipts/client/js/templates/TemplateListPane.jsx
Outdated
Show resolved
Hide resolved
pferreir
force-pushed
the
add-receipt-templates
branch
from
6003304 to
6dc941e
Compare
pferreir
force-pushed
the
add-receipt-templates
branch
6 times, most recently
from
8bedb3a to
929e845
Compare
pferreir
force-pushed
the
add-receipt-templates
branch
from
929e845 to
0566b78
Compare
pferreir
force-pushed
the
add-receipt-templates
branch
from
0566b78 to
f862a97
Compare
pferreir
force-pushed
the
add-receipt-templates
branch
4 times, most recently
from
df54e8d to
4f37be0
Compare
pferreir
force-pushed
the
add-receipt-templates
branch
from
4f37be0 to
91aa53a
Compare
ThiefMaster
force-pushed
the
add-receipt-templates
branch
3 times, most recently
from
2e6e592 to
84d7c4f
Compare
ThiefMaster
reviewed
Aug 24, 2023
ThiefMaster
force-pushed
the
add-receipt-templates
branch
from
84d7c4f to
dd37e5c
Compare
duartegalvao
force-pushed
the
add-receipt-templates
branch
from
dd37e5c to
18d40eb
Compare
That way comments, yaml multiline strings etc. are preserved instead of converted back from JSON to YAML
ThiefMaster
force-pushed
the
add-receipt-templates
branch
from
20054ea to
317e5ab
Compare
Also fix improper routing usage that caused full remounts instead of just updating the existing component
- shorten message duration - fix another stuck qtip
ThiefMaster
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.