Skip to content

Allow disabling public search of Indico users #5024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OmeGak wants to merge 3 commits into from
Closed

Allow disabling public search of Indico users #5024

OmeGak wants to merge 3 commits into from

Conversation

@OmeGak
Copy link
Member

@OmeGak OmeGak commented Jul 28, 2021 •
edited
Loading

This PR makes it possible for Indico instances to limit searching users by email to only managers. This includes:

  • Disabling registering to events as a different user than the one logged in.
  • Disabling speakers to give access to specific users/groups in protected uploaded material.
  • Disabling users to add other users as author/co-author in abstract submissions (details must be added manually).

@OmeGak OmeGak force-pushed the wip/public-user-search branch 6 times, most recently from 27fe09a to ef4687e Compare August 4, 2021 13:07
@OmeGak OmeGak force-pushed the wip/public-user-search branch 5 times, most recently from b4cdddf to 8988c34 Compare August 9, 2021 09:21
ThiefMaster
ThiefMaster reviewed Aug 10, 2021
View reviewed changes
@OmeGak OmeGak force-pushed the wip/public-user-search branch 4 times, most recently from ccf8dcd to 8a787ee Compare August 11, 2021 16:48
@ThiefMaster ThiefMaster force-pushed the wip/public-user-search branch from 8a787ee to 4670cdd Compare August 13, 2021 09:50
ThiefMaster
ThiefMaster reviewed Aug 13, 2021
View reviewed changes
@ThiefMaster ThiefMaster force-pushed the wip/public-user-search branch from 853da35 to ed322fd Compare August 13, 2021 11:23
ThiefMaster
ThiefMaster reviewed Aug 16, 2021
View reviewed changes
@OmeGak OmeGak force-pushed the wip/public-user-search branch from ed322fd to 0d9d09b Compare August 16, 2021 12:45
@ThiefMaster ThiefMaster force-pushed the wip/public-user-search branch from 0d9d09b to ed322fd Compare August 16, 2021 12:52
@OmeGak OmeGak force-pushed the wip/public-user-search branch from ed322fd to fbe27bb Compare August 17, 2021 16:48
ThiefMaster
ThiefMaster reviewed Aug 18, 2021
View reviewed changes
@OmeGak OmeGak force-pushed the wip/public-user-search branch from fbe27bb to b367d95 Compare August 18, 2021 14:10
ThiefMaster
ThiefMaster reviewed Aug 24, 2021
View reviewed changes
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are also a bunch of linter warnings

@ThiefMaster
Copy link
Member

ThiefMaster commented Aug 25, 2021

The "Add Indico user" button on /user/favorites/ should be disabled or hidden when public search is disabled. Same for the backend that adds a new favorite user as one could just bruteforce-add all the user ids to the favorites and then view them on that page.

Some widgets (mostly simple ACL widgets like the one used in the room booking settings) already support marking any user there as a favorite, but eventually we can add this everywhere or even in the user search result dialog (but not needed in this PR).

@ThiefMaster
Copy link
Member

ThiefMaster commented Aug 25, 2021

RHPrincipals / RHEventPrincipals need the same kind of protection as RHUserSearch

@OmeGak OmeGak force-pushed the wip/public-user-search branch from b367d95 to 9e9c607 Compare September 14, 2021 15:51
@OmeGak
Copy link
Member Author

OmeGak commented Sep 15, 2021

The "Add Indico user" button on /user/favorites/ should be disabled or hidden when public search is disabled.

Done.

@OmeGak OmeGak force-pushed the wip/public-user-search branch from 9e9c607 to 055f69e Compare September 15, 2021 12:44
@OmeGak OmeGak force-pushed the wip/public-user-search branch from 055f69e to 4815d34 Compare September 15, 2021 14:10
@ThiefMaster ThiefMaster mentioned this pull request Nov 17, 2021
Open
@ThiefMaster ThiefMaster mentioned this pull request Dec 2, 2022
Merged
@kewisch
Copy link
Contributor

kewisch commented May 25, 2023

@OmeGak Would you have some time to update this PR so we can get it merged? I'd love to make use of this in our instance.

@OmeGak
Copy link
Member Author

OmeGak commented Jun 6, 2023

Hi @kewisch. It's been some time I didn't work on this PR after I bumped into a few non-trivial corner cases. I can find some time to rebase the code onto the current master but I don't think I will be able to finish it for now, as it's not a priority for my client. If you would like to have it finished urgently, maybe @ThiefMaster can guide you through whatever was missing?

@ThiefMaster ThiefMaster changed the base branch from 3.0.x to master July 21, 2023 11:00
@ThiefMaster ThiefMaster marked this pull request as draft March 21, 2024 16:42
@OmeGak OmeGak mentioned this pull request Apr 18, 2025
Open
@ThiefMaster ThiefMaster mentioned this pull request Jul 4, 2025
Merged
3 tasks
@ThiefMaster
Copy link
Member

ThiefMaster commented Jul 4, 2025

superseded by #6960

@ThiefMaster ThiefMaster closed this Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThiefMaster ThiefMaster ThiefMaster left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OmeGak @ThiefMaster @kewisch