Fix inconsistent heading fragment IDs #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation for sharing the anchor generation logic with ToC renderer and also for performance improvement.
... with the anchors generated by Greenmat::HTMLRenderer.
yujinakayama
changed the title
Contributor
|
spec/qiita/markdown/processor_spec.rb が成功していれば良いと思います |
Contributor
Author
|
Thanks! |
yujinakayama
added a commit
that referenced
this pull request
Apr 20, 2015
Fix inconsistent heading fragment IDs
yujinakayama
added a commit
that referenced
this pull request
Jun 16, 2017
... so that Greenmat filter won't generate FontAwesome classes and we can say that they're inputted by user if they exist. This partially reverts #12.
yujinakayama
added a commit
that referenced
this pull request
Jun 16, 2017
... so that Greenmat filter won't generate FontAwesome classes and we can say that they're inputted by user if they exist. This partially reverts #12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we've generated heading anchors in custom post-process with
HTML::Pipeline. However fragment IDs of the anchor may be inconsistent when we use::Greenmat::Render::HTML_TOCrenderer directly.This change fixes the inconsistent fragment IDs by generating the IDs in renderers rather than post-process, and also doing so improve the overall rendering performance.