Repository navigation
test(desktop): verify native browser viewport captures in CI - #841
Merged
Merged
Conversation
Upstream divergenceBoth sides are compared with upstream at the in-order tip
Upstream files whose difference changes (2)
|
…tion-ci # Conflicts: # .github/workflows/fork-ci.yml
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
incognitojam
pushed a commit
that referenced
this pull request
Oct 16, 2026
…dentity (pingdotgg#16032) Fork adaptation: The backend shutdown finalizer keeps the fork's span and trace flush (fork #203) and adds upstream's renderer history shutdown before the shutdown marker completes. The fork-only browser calibration harness (fork #841) now provides a no-op renderer history, because the preview manager requires the new service. (cherry picked from commit 7b797f2) Upstream-PR: 16032 Fork-Feature: desktop-graceful-shutdown, preview-surface-continuity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viewport rendering can regress while browser operations still return success. Add a native desktop integration check that exercises the production viewport calculation, a real Electron webview, PreviewManager's CDP emulation and snapshot capture, and locator clicks.
The active fork CI workflow runs thirteen zoom/resize scenarios on Linux and macOS and gates
Fork Checkon both results. Each scenario verifies 36 reference pixels, CSS dimensions, screenshot geometry, page console errors, and click alignment. Captures and scalar measurements are uploaded as CI artifacts.Coverage is deliberately bounded: this creates a minimal host page and applies calculated webview dimensions directly. It bypasses the React Browser panel and toolbar, surface ownership/reparenting, IPC, the server/MCP transport, providers, and remote/relay connections. The small-preview and resized-back cases resize the same webview; they do not simulate mini-player or hide/reopen transitions. This is a native rendering/capture/input regression test, not a complete app end-to-end test.
Validation: all thirteen scenarios passed on macOS and in an isolated Linux container; removing window-zoom compensation caused a pixel assertion to fail. Targeted lint/format, scoped unused-code checks, feature-ledger validation, and actionlint passed. No production behavior or telemetry changes are included.
macOS capture at 120% window zoom and 110% page zoom:
Linux phone capture:
Written by an agent (Codex, gpt-6.1-sol).