Repository navigation
fix(chat): answered questions stay visible outside collapsed work - #839
Merged
Merged
Conversation
incognitojam
enabled auto-merge (squash)
October 15, 2026 11:10
Upstream divergenceBoth sides are compared with upstream at the in-order tip
Upstream files whose difference changes (5)
|
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
incognitojam
pushed a commit
that referenced
this pull request
Oct 29, 2026
) Fork adaptation: The fork also kept a continued run's first assistant message outside the fold; that clause goes with upstream's removal of the first-message rule. Upstream's answered-question checks replace the fork's equivalent ones from fork #839 in the standalone-activity test and the fold exclusions, and the pending-question-answer-history ledger entry now tracks 21393. (cherry picked from commit 77e4f56) Upstream-PR: 21393 Fork-Feature: pending-question-answer-history
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Submitted questions and answers remain visible outside collapsed work across clients, restoring the earlier timeline behavior.
Problem
After answering an agent question, the submitted answer is saved and reaches the provider, but its question row joins ordinary tool groups and completed-turn folds. A collapsed conversation can show the original prompt and final reply with no visible record of the intervening question or answer.
Change
Keep submitted question history in its own expandable row on web, desktop, and mobile, outside active tool groups and completed-turn folds. Reuse the existing question, answer preview, and expanded history presentation. On mobile, expanded answer history also omits duplicate raw request metadata.
This restores the visibility behavior from pingdotgg#11363 that was lost during pingdotgg#2829. Record the maintained behavior and current upstream overlap in the fork ledger.
Scope and approval
Requested by the maintainer to fix missing question-and-answer history and open a styal PR. The change affects client presentation of already-persisted answers. Answers from superseded attempts can still require expanding that attempt.
Verification
MessagesTimeline.logic.test.ts,MessagesTimeline.test.tsx, and mobilethreadActivity.test.ts. Regression-specific tests fail on the original code and cover running/completed turns, questions followed by more work, and fold/group expansion. Web and mobile typechecks, formatting, and ledger validation pass. Scoped lint passes with existing warnings on unchanged lines.Expanded answer details · 390px web layout
Written by an agent (Codex, gpt-6.1-sol).