Repository navigation
fix(web): make floating browser preview view-only - #526
Merged
Merged
Conversation
incognitojam
added
the
preview:mac
macOS previewThe preview download was removed because this PR closed or the preview label was removed. |
incognitojam
marked this pull request as ready for review
September 28, 2026 19:48
incognitojam
pushed a commit
that referenced
this pull request
Sep 29, 2026
Co-authored-by: Claude Code <[email protected]> Fork adaptation: The browser source keeps fork #197's corner geometry, a 14px frame with the content inset inside the 1px ring and clipped at 13px, and fork #526's view-only shield (preview-surface-continuity), now a shell option only the browser source sets, so floating device streams stay interactive as upstream intends. Agent opens keep the fork's right-panel presentation. The devices guide keeps styal naming. (cherry picked from commit 8bbe2bf) Upstream-PR: 11285
incognitojam
pushed a commit
that referenced
this pull request
Sep 29, 2026
Co-authored-by: Claude Code <[email protected]> Fork adaptation: The browser source keeps fork #197's corner geometry, a 14px frame with the content inset inside the 1px ring and clipped at 13px, and fork #526's view-only shield (preview-surface-continuity), now a shell option only the browser source sets, so floating device streams stay interactive as upstream intends. Agent opens keep the fork's right-panel presentation. The devices guide keeps styal naming. (cherry picked from commit 8bbe2bf) Upstream-PR: 11285
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The floating browser preview over chat let clicks, scrolling, and keyboard focus reach the live page, even though the small window is intended for monitoring. That made accidental page changes easy while working in chat.
The floating preview now shields the page from pointer input and makes its hosted webview inert while preserving the live picture. Its move, resize, open-in-panel, and close controls remain usable. Opening the preview in the right panel restores normal page interaction. The fork feature ledger records this behavior.
Validation: focused web tests passed (26 tests), web typecheck passed, the fork feature ledger validated, and CI passed on the PR commit. A paired local web client loaded without page errors. The requester tested the macOS preview build and reported that the floating preview seemed noninteractive. I could not independently capture an Electron interaction test; this change has no intended visual difference to show in static before/after images.
Written by an agent (Codex, GPT-6).