Repository navigation
refactor(pull-requests): remove the Summary tab stack ladder - #522
Merged
Merged
Conversation
Upstream's GitHub stack support, now on main, shows every layer in a popover from the header badge, adds stack badges to the pull request list, groups linked stacks, and offers Merge stack and Rebase stack. The fork's Stack section on the Summary tab repeated the popover's information and cost a separate GraphQL read on every detail load. This removes the section, the stack read and decoder behind it, the detail field in the contract, their tests, the user guide bullet, and the fork feature ledger entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request detail view showed a GitHub stack twice. The Stack section on the Summary tab lists every layer (fork #194). Upstream's stack support, now on main from pingdotgg#10839, pingdotgg#10870 and pingdotgg#10875, lists the same layers, branches and states in a popover from the header's position badge (
3/6). Upstream also adds stack badges to the pull request list, links and groups a whole stack in the Linked pull requests panel, and offers Merge stack and Rebase stack. The fork's section also made a separate GraphQL request on every detail load.This removes the fork's version:
getPullRequestStackLadderGraphQL read, its decoder, and thestackLadderdetail field in the contractstacked-pull-request-navigationfork feature ledger entryOpening a layer beside the thread (fork #329) is not affected: upstream's popover opens a layer as a tab beside the thread, and PR links in descriptions and comments still use the fork's link opener, which the
github-reference-linksledger entry covers.Validation
Web client in a local dev server, with a project whose remote is
pingdotgg/t3code, on the open six-layer stack pingdotgg#13565:3/6badge opens the popover listing all six layers, with the current one checked.Focused checks: typecheck for contracts, server and web; the GitHub provider, JSON decoder and pull request service tests (235 pass); fork feature ledger validation.
Written by an agent (Claude Code, claude-opus-5-5).