Repository navigation
fix(web): show a lone setup action as one row - #500
Merged
Merged
Conversation
A completed setup action is an info-tone entry with no command, so the timeline treated it as a non-tool entry and wrapped it in a group toggle. Expanding the toggle showed the same row again. A group holding only a setup-script entry now renders as a plain work row, like failed and stopped setup actions already do. The group toggle's setup icon and status mark were only reachable through that case and are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A completed setup action (for example "Setup Worktree completed") showed up in the chat timeline as an expandable group. Expanding it revealed a second, identical row.
The timeline shows a single entry as a plain row only when it is tool-like. A completed setup action is an info-tone entry with no command, so it fell through to the group toggle path as a one-entry group. That entry has nothing to expand on success, so the expanded group only repeated it.
A group holding just one setup-script entry now renders as a plain work row. Failed and stopped setup actions already render this way, and the plain row keeps the configured action icon and the completed, failed, or stopped mark. The group toggle's setup icon and status mark were only reachable through the one-entry case, so they are removed.
Mobile is unchanged: it wraps every group, including single tool calls, in a toggle, so a setup row there follows the same pattern as other rows.
The after screenshot uses the light theme.
Validation
MessagesTimeline.logic.test.tscase: a lone completed setup action produces aworkrow and nowork-toggle. It fails without the logic change.MessagesTimeline.logic.test.tsandMessagesTimeline.test.tsxpass (166 tests), including the existing setup action icon and state tests. Web typecheck is clean.Upstream replaced these rows with a worktree setup card (
pingdotgg/t3code#11372,#11832,#12015), which is past the current intake baseline. This fix covers the fork's rows until that intake decides between the card and the rows.Written by an agent (Claude Code, claude-opus-5-5).