Repository navigation
fix(web): keep pull request diffs stable during refresh - #457
Merged
Merged
Conversation
incognitojam
marked this pull request as ready for review
September 25, 2026 11:03
incognitojam
marked this pull request as draft
September 25, 2026 11:12
incognitojam
marked this pull request as ready for review
September 25, 2026 11:27
incognitojam
pushed a commit
that referenced
this pull request
Oct 30, 2026
…ingdotgg#19701) Co-authored-by: Claude Opus 5.5 <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Fork adaptation: Retain fork stale-check-summary and refresh recovery browser fixtures from 9ad6a0b (the adapted pingdotgg#20901 import), combining them with upstream's read-only PR selection scenarios through the existing liveDetail fixture. Line selection keeps fork #457's refresh guard, so a draft cannot switch from Add to review to Add to agent while the diff refreshes. (cherry picked from commit ee3a3e8) Upstream-PR: 19701 Fork-Feature: pull-request-live-refresh, pull-request-required-checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Finishing an unrelated agent turn could reload an open PR's Code tab. A refresh also hid the diff behind a loading skeleton.
Change
Checked
An agent turn and an inline conversation on a current hunk were not exercised in the browser.
Evidence
Before/after video: the left side clears during refresh; the right side keeps the diff visible.
Written by an agent (Codex, GPT-6).