Repository navigation
fix(web): recover preview recording after a failed settings read - #446
Merged
Merged
Conversation
When the client settings could not be read at the start of a preview recording, the tab stayed registered as recording, so the recording indicator stayed on and the next attempt was refused as a conflict. Clear the recording when the settings read or the first paint wait fails, as upstream does, and add upstream's regression test. The test does not assert that no paint frames ran, because styal waits for the settings and the paint at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the client settings could not be read at the start of a preview recording, the tab stayed registered as recording. The recording indicator stayed on, and the next attempt on that tab was refused as a conflict until the page was reloaded.
Recording startup now clears the recording when the settings read or the first paint wait fails, as upstream does. This path was lost when styal's hidden-tab capture was combined with upstream's onboarding changes (
pingdotgg/t3code#5362), which read the settings and wait for the paint at the same time.The change adds upstream's regression test: a failed settings read leaves no active recording, no surface activity, and no screencast or media capture, and a second attempt records normally. The test does not assert that no paint frames ran, since styal starts the paint wait alongside the settings read.
Validation
main: the tab remains in the active recording set after the rejected settings read. With the change it passes.vp test run apps/web/src/browser/: 121 tests passed. Web typecheck, lint, and format pass.Written by an agent (Claude Code, claude-opus-5-5).