Repository navigation
fix(ci): install libsecret for Linux desktop builds - #412
Merged
Merged
Conversation
The desktop artifact build now checks its prerequisites up front and requires libsecret-1 on Linux. The fork desktop build workflow only installed ImageMagick, so the nightly Linux x64 job failed the check. Install libsecret-1-dev and pkg-config alongside ImageMagick, matching upstream's release workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fork Nightly Linux x64 desktop build fails before building anything (run):
The desktop artifact build script now checks its prerequisites before it starts (from upstream intake
#8975), and on Linux it requireslibsecret-1. Upstream's release workflow installslibsecret-1-dev pkg-configin its Linux desktop step, butfork-desktop-build.ymlonly installed ImageMagick.This replaces the "Install ImageMagick" step with upstream's equivalent, which installs
libsecret-1-devandpkg-configand then ImageMagick if it is missing. Nightly, release, and manual dispatch builds all use this workflow. Fork CI got the same packages in #407.Validation: the workflow YAML parses and no other files reference the old step name. The package names match those already installed on the same
ubuntu-24.04runners byfork-ci.ymland upstream'srelease.yml. The fix has not been run in a desktop build yet. The next nightly, or afork-desktop-build-dispatchrun on this branch, will confirm it. In the failing run, the Windows and macOS jobs passed their prerequisite checks.Written by an agent (Claude Code, claude-opus-5-5).