Repository navigation
fix(web): align floating preview corners - #197
Merged
Merged
Conversation
yngatech-nightly
Bot
force-pushed
the
main
branch
from
August 18, 2026 18:14
a83dced to
c38a9eb
Compare
incognitojam
force-pushed
the
t3code/fix-browser-preview-border-radius-1
branch
from
August 18, 2026 20:22
e49b02f to
6253a89
Compare
incognitojam
force-pushed
the
t3code/fix-browser-preview-border-radius-1
branch
from
August 18, 2026 20:48
6253a89 to
0ae331b
Compare
incognitojam
marked this pull request as ready for review
August 18, 2026 20:48
incognitojam
enabled auto-merge (squash)
August 18, 2026 20:48
incognitojam
added a commit
that referenced
this pull request
Aug 19, 2026
The floating browser preview clipped its native browser surface at 12px while the visible frame and inset ring resolved to 14px. The webview also filled the frame beneath its translucent inset ring, making page content appear outside the outline. This change aligns the outer layers at a 14px radius, then places the browser content inside the 1px border with a 13px inner radius. ## Verification - `vp test run apps/web/src/browser/hostedBrowserWebviewStyle.test.ts` - `vp run --filter @t3tools/web typecheck` - Before/after visual verification performed by the maintainer in the desktop client ## Screenshots Before/after screenshots were captured and reviewed by the maintainer but are not embedded in this PR. --- Written by an agent (T3 Code, gpt-5.6-sol). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
yngatech-nightly Bot
pushed a commit
that referenced
this pull request
Aug 20, 2026
The floating browser preview clipped its native browser surface at 12px while the visible frame and inset ring resolved to 14px. The webview also filled the frame beneath its translucent inset ring, making page content appear outside the outline. This change aligns the outer layers at a 14px radius, then places the browser content inside the 1px border with a 13px inner radius. ## Verification - `vp test run apps/web/src/browser/hostedBrowserWebviewStyle.test.ts` - `vp run --filter @t3tools/web typecheck` - Before/after visual verification performed by the maintainer in the desktop client ## Screenshots Before/after screenshots were captured and reviewed by the maintainer but are not embedded in this PR. --- Written by an agent (T3 Code, gpt-5.6-sol). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
yngatech-nightly Bot
pushed a commit
that referenced
this pull request
Aug 21, 2026
The floating browser preview clipped its native browser surface at 12px while the visible frame and inset ring resolved to 14px. The webview also filled the frame beneath its translucent inset ring, making page content appear outside the outline. This change aligns the outer layers at a 14px radius, then places the browser content inside the 1px border with a 13px inner radius. ## Verification - `vp test run apps/web/src/browser/hostedBrowserWebviewStyle.test.ts` - `vp run --filter @t3tools/web typecheck` - Before/after visual verification performed by the maintainer in the desktop client ## Screenshots Before/after screenshots were captured and reviewed by the maintainer but are not embedded in this PR. --- Written by an agent (T3 Code, gpt-5.6-sol). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
incognitojam
added a commit
that referenced
this pull request
Aug 27, 2026
The floating browser preview clipped its native browser surface at 12px while the visible frame and inset ring resolved to 14px. The webview also filled the frame beneath its translucent inset ring, making page content appear outside the outline. This change aligns the outer layers at a 14px radius, then places the browser content inside the 1px border with a 13px inner radius. ## Verification - `vp test run apps/web/src/browser/hostedBrowserWebviewStyle.test.ts` - `vp run --filter @t3tools/web typecheck` - Before/after visual verification performed by the maintainer in the desktop client ## Screenshots Before/after screenshots were captured and reviewed by the maintainer but are not embedded in this PR. --- Written by an agent (T3 Code, gpt-5.6-sol). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
incognitojam
added a commit
that referenced
this pull request
Aug 28, 2026
The floating browser preview clipped its native browser surface at 12px while the visible frame and inset ring resolved to 14px. The webview also filled the frame beneath its translucent inset ring, making page content appear outside the outline. This change aligns the outer layers at a 14px radius, then places the browser content inside the 1px border with a 13px inner radius. ## Verification - `vp test run apps/web/src/browser/hostedBrowserWebviewStyle.test.ts` - `vp run --filter @t3tools/web typecheck` - Before/after visual verification performed by the maintainer in the desktop client ## Screenshots Before/after screenshots were captured and reviewed by the maintainer but are not embedded in this PR. --- Written by an agent (T3 Code, gpt-5.6-sol). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
incognitojam
pushed a commit
that referenced
this pull request
Sep 29, 2026
Co-authored-by: Claude Code <[email protected]> Fork adaptation: The browser source keeps fork #197's corner geometry, a 14px frame with the content inset inside the 1px ring and clipped at 13px, and fork #526's view-only shield (preview-surface-continuity), now a shell option only the browser source sets, so floating device streams stay interactive as upstream intends. Agent opens keep the fork's right-panel presentation. The devices guide keeps styal naming. (cherry picked from commit 8bbe2bf) Upstream-PR: 11285
incognitojam
pushed a commit
that referenced
this pull request
Sep 29, 2026
Co-authored-by: Claude Code <[email protected]> Fork adaptation: The browser source keeps fork #197's corner geometry, a 14px frame with the content inset inside the 1px ring and clipped at 13px, and fork #526's view-only shield (preview-surface-continuity), now a shell option only the browser source sets, so floating device streams stay interactive as upstream intends. Agent opens keep the fork's right-panel presentation. The devices guide keeps styal naming. (cherry picked from commit 8bbe2bf) Upstream-PR: 11285
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The floating browser preview clipped its native browser surface at 12px while the visible frame and inset ring resolved to 14px. The webview also filled the frame beneath its translucent inset ring, making page content appear outside the outline.
This change aligns the outer layers at a 14px radius, then places the browser content inside the 1px border with a 13px inner radius.
Verification
vp test run apps/web/src/browser/hostedBrowserWebviewStyle.test.tsvp run --filter @t3tools/web typecheckScreenshots
Before/after screenshots were captured and reviewed by the maintainer but are not embedded in this PR.
Written by an agent (T3 Code, gpt-5.6-sol).