Repository navigation
chore(upstream): track the hand-ported Stop fix for upstream #23886 - #1120
Merged
Merged
Conversation
Upstream divergenceBoth sides are compared with upstream at the in-order tip
No upstream file changes how much it differs from upstream. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork #1116 hand-ported the Stop fix from pingdotgg#23886 without an
Upstream-PRtrailer, because that PR depends on 23 earlier upstream commits the fork had not taken in. The queue therefore still lists pingdotgg#23886 as pending, and nothing told whoever runs intake that its code is already in place.This adds a tracked entry for pingdotgg#23886 in
.github/upstream-tracked-prs.json. Its reason says that when chronological intake reaches the PR, the cherry-pick should change no code (to be checked, not assumed), and that the fork keeps #1116's correction to the Stop paragraph indocs/orchestration-v2/feature-lifecycles.md, which upstream still describes as sendingrun.interruptwithholdQueue.Validation:
node scripts/upstream/queue.ts status --fork-ref HEADdecodes the file and lists pingdotgg#23886 as pending (beyond the current target) with this reason. A comparison of fork commit 1dc42d7 with upstream commit fbc6a08 found that their code and test changes match apart from indentation.Written by an agent (Claude Code, claude-opus-5-5).