Skip to content

Commit ad38700

Browse files
chore(macroscope): review diagnostic overrides (pingdotgg#8917)
Co-authored-by: Julius Marminge <[email protected]>
1 parent f86c5e8 commit ad38700

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

‎.macroscope/approvability.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
11
Use Macroscope's default approvability criteria.
22

33
Additionally, any pull request that changes product defaults is not auto-approvable and requires human review.
4+
5+
Any pull request that adds or broadens a directive that disables or suppresses a lint,
6+
type-checker, LSP, or other static-analysis diagnostic is not auto-approvable and requires
7+
human review. This includes file-level, line-level, and configuration-level overrides.

‎.macroscope/check-run-agents/effect-service-conventions.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ Review changed TypeScript and directly affected call sites for the conventions b
8282
## Change discipline
8383

8484
- Preserve useful comments, invariants, and specification documentation while moving code.
85+
- Require every new or broadened directive that disables or suppresses a lint, type-checker, LSP, or other static-analysis diagnostic to have an adjacent comment explaining why that diagnostic must be disabled there. The directive itself is not an explanation. Report a missing explanation as a concrete violation.
8586
- Do not add large tests solely to prove a mechanical refactor. Update existing tests and imports as needed.
8687
- If backend behavior changes, require focused tests. Use test implementations/layers for external services only; do not mock out core business logic.
8788
- Do not require `Layer.effect`, universal namespace imports, generic `make`/`layer` names for abstract-port implementations, separate error classes for diagnostic-only fields, or new tests for import-only changes.

0 commit comments

Comments
 (0)