Skip to content

Commit a72b58e

Browse files
fix(web): settings search keeps the clamped highlight when results shrink (pingdotgg#20764)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent 33672c4 commit a72b58e

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

‎apps/web/src/components/settings/SettingsSidebarNav.tsx‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,12 +118,16 @@ export function SettingsSidebarNav({ pathname }: { pathname: string }) {
118118
const { isMobile, setOpenMobile, open, setOpen } = useSidebar();
119119
const searchInputRef = useRef<HTMLInputElement>(null);
120120
const [query, setQuery] = useState("");
121-
const [storedActiveResultIndex, setActiveResultIndex] = useState(0);
121+
const [activeResultIndex, setActiveResultIndex] = useState(0);
122122
const searchableItems = useAvailableSettingsSearchItems(scopeSearch);
123123
const results = searchSettings(query, searchableItems);
124124
const isSearching = query.trim().length > 0;
125125
const hasResults = results.length > 0;
126-
const activeResultIndex = Math.min(storedActiveResultIndex, Math.max(results.length - 1, 0));
126+
const maxResultIndex = Math.max(results.length - 1, 0);
127+
// Persist the clamp so a shrink-then-recover of results keeps the clamped highlight.
128+
if (activeResultIndex > maxResultIndex) {
129+
setActiveResultIndex(maxResultIndex);
130+
}
127131

128132
useEffect(() => {
129133
const result = results[activeResultIndex];

0 commit comments

Comments
 (0)