@@ -19,6 +19,8 @@ import {
1919 EnvironmentId ,
2020 EventId ,
2121 MessageId ,
22+ OrchestrationThreadShell ,
23+ ProjectId ,
2224 PROVIDER_SEND_TURN_MAX_INPUT_CHARS ,
2325 ProviderDriverKind ,
2426 ProviderInstanceId ,
@@ -75,6 +77,7 @@ import * as ServerConfig from "../../config.ts";
7577import * as ServerSettings from "../../serverSettings.ts" ;
7678import * as AnalyticsService from "../../telemetry/AnalyticsService.ts" ;
7779import { makeAdapterRegistryMock } from "../testUtils/providerAdapterRegistryMock.ts" ;
80+ import * as ProjectionSnapshotQuery from "../../orchestration/Services/ProjectionSnapshotQuery.ts" ;
7881
7982const defaultServerSettingsLayer = ServerSettings . ServerSettingsService . layerTest ( ) ;
8083const serverConfigTestLayer = ServerConfig . layerTest ( process . cwd ( ) , process . cwd ( ) ) . pipe (
@@ -4302,10 +4305,17 @@ boundedListing.layer("ProviderServiceLive session listing", (it) => {
43024305 ) ;
43034306} ) ;
43044307
4308+ const decodeBrowserAccessThreadShell = Schema . decodeUnknownEffect ( OrchestrationThreadShell ) ;
4309+
43054310describe ( "agent browser access" , ( ) => {
43064311 const revokedThreads : Array < ThreadId > = [ ] ;
4312+ const projectId = ProjectId . make ( "project-browser-access" ) ;
43074313
4308- const startSessionWith = ( enableAgentBrowserAccess : boolean , threadId : ThreadId ) =>
4314+ const startSessionWith = (
4315+ enableAgentBrowserAccess : boolean ,
4316+ threadId : ThreadId ,
4317+ projectOverride ?: boolean ,
4318+ ) =>
43094319 Effect . gen ( function * ( ) {
43104320 const issued : Array < ThreadId > = [ ] ;
43114321 const codex = makeFakeCodexAdapter ( ) ;
@@ -4319,6 +4329,49 @@ describe("agent browser access", () => {
43194329 const directoryLayer = ProviderSessionDirectoryLive . pipe (
43204330 Layer . provide ( runtimeRepositoryLayer ) ,
43214331 ) ;
4332+ const projectionLayer = Layer . succeed ( ProjectionSnapshotQuery . ProjectionSnapshotQuery , {
4333+ getImportedAgentSessionSources : ( ) => Effect . die ( "unused" ) ,
4334+ getUserInputActivity : ( ) => Effect . die ( "unused" ) ,
4335+ getCommandReadModel : ( ) => Effect . die ( "unused" ) ,
4336+ getSnapshot : ( ) => Effect . die ( "unused" ) ,
4337+ getShellSnapshot : ( ) => Effect . die ( "unused" ) ,
4338+ getArchivedShellSnapshot : ( ) => Effect . die ( "unused" ) ,
4339+ getSnapshotSequence : ( ) => Effect . die ( "unused" ) ,
4340+ getCounts : ( ) => Effect . die ( "unused" ) ,
4341+ getEventReplayStats : ( ) => Effect . die ( "unused" ) ,
4342+ getActiveProjectByWorkspaceRoot : ( ) => Effect . die ( "unused" ) ,
4343+ getProjectShellById : ( ) => Effect . die ( "unused" ) ,
4344+ getFirstActiveThreadIdByProjectId : ( ) => Effect . die ( "unused" ) ,
4345+ getThreadCheckpointContext : ( ) => Effect . die ( "unused" ) ,
4346+ getFullThreadDiffContext : ( ) => Effect . die ( "unused" ) ,
4347+ getThreadRuntimeContext : ( ) => Effect . die ( "unused" ) ,
4348+ getThreadShellById : ( requestedThreadId ) =>
4349+ Effect . gen ( function * ( ) {
4350+ assert . equal ( requestedThreadId , threadId ) ;
4351+ return Option . some (
4352+ yield * decodeBrowserAccessThreadShell ( {
4353+ id : threadId ,
4354+ projectId,
4355+ title : "Browser access test" ,
4356+ modelSelection : createModelSelection ( codexInstanceId , "gpt-5.4" ) ,
4357+ runtimeMode : "full-access" ,
4358+ branch : null ,
4359+ worktreePath : null ,
4360+ latestTurn : null ,
4361+ createdAt : "2026-01-01T00:00:00.000Z" ,
4362+ updatedAt : "2026-01-01T00:00:00.000Z" ,
4363+ session : null ,
4364+ latestUserMessageAt : null ,
4365+ hasPendingApprovals : false ,
4366+ hasPendingUserInput : false ,
4367+ hasActionableProposedPlan : false ,
4368+ } ) ,
4369+ ) ;
4370+ } ) . pipe ( Effect . orDie ) ,
4371+ getThreadDetailById : ( ) => Effect . die ( "unused" ) ,
4372+ getThreadDetailSnapshot : ( ) => Effect . die ( "unused" ) ,
4373+ searchThreads : ( ) => Effect . die ( "unused" ) ,
4374+ } ) ;
43224375 const providerLayer = makeProviderServiceLive ( {
43234376 issueMcpCredential : ( request ) =>
43244377 Effect . sync ( ( ) => {
@@ -4329,7 +4382,14 @@ describe("agent browser access", () => {
43294382 } ) . pipe (
43304383 Layer . provide ( providerAdapterLayer ) ,
43314384 Layer . provide ( directoryLayer ) ,
4332- Layer . provide ( ServerSettings . ServerSettingsService . layerTest ( { enableAgentBrowserAccess } ) ) ,
4385+ Layer . provide ( projectionLayer ) ,
4386+ Layer . provide (
4387+ ServerSettings . ServerSettingsService . layerTest ( {
4388+ enableAgentBrowserAccess,
4389+ projectAgentBrowserAccessOverrides :
4390+ projectOverride === undefined ? { } : { [ projectId ] : projectOverride } ,
4391+ } ) ,
4392+ ) ,
43334393 Layer . provide ( serverConfigTestLayer ) ,
43344394 Layer . provide ( AnalyticsService . layerTest ) ,
43354395 Layer . provide (
@@ -4387,4 +4447,22 @@ describe("agent browser access", () => {
43874447 assert . deepEqual ( issued , [ threadId ] ) ;
43884448 } ) . pipe ( Effect . provide ( NodeServices . layer ) ) ,
43894449 ) ;
4450+
4451+ it . effect ( "withholds and revokes MCP credentials when the project disables browser access" , ( ) =>
4452+ Effect . gen ( function * ( ) {
4453+ const threadId = asThreadId ( "thread-project-browser-off" ) ;
4454+ revokedThreads . length = 0 ;
4455+ const issued = yield * startSessionWith ( true , threadId , false ) ;
4456+ assert . deepEqual ( issued , [ ] ) ;
4457+ assert . deepEqual ( revokedThreads , [ threadId ] ) ;
4458+ } ) . pipe ( Effect . provide ( NodeServices . layer ) ) ,
4459+ ) ;
4460+
4461+ it . effect ( "requests an MCP credential when the project overrides browser access to on" , ( ) =>
4462+ Effect . gen ( function * ( ) {
4463+ const threadId = asThreadId ( "thread-project-browser-on" ) ;
4464+ const issued = yield * startSessionWith ( false , threadId , true ) ;
4465+ assert . deepEqual ( issued , [ threadId ] ) ;
4466+ } ) . pipe ( Effect . provide ( NodeServices . layer ) ) ,
4467+ ) ;
43904468} ) ;
0 commit comments