Skip to content

Commit 9eac774

Browse files
test(mobile): run React hooks with the release compiler (pingdotgg#24274)
1 parent 5a38e6b commit 9eac774

5 files changed

Lines changed: 246 additions & 5 deletions

File tree

‎apps/mobile/src/features/pull-requests/PullRequestInlineCommentScreen.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export function PullRequestInlineCommentScreen({ route }: StaticScreenProps<Inli
3333
const body = editedBody ?? saved?.body ?? "";
3434
const detail = useEnvironmentQuery(composerPullRequests.detail(pullRequestTarget(params)));
3535
const { refresh: refreshDetail } = detail;
36-
useFocusEffect(() => refreshDetail());
36+
useFocusEffect(refreshDetail);
3737
const permissions = usePullRequestPermissions(params, detail.data);
3838
const stale = detail.data && detail.data.headSha !== params.headSha;
3939
const pending = useRef(false);

‎apps/mobile/src/features/pull-requests/PullRequestReviewSheet.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export function PullRequestReviewSheet({
6868
const target = pullRequestTarget(params);
6969
const result = useEnvironmentQuery(composerPullRequests.detail(target));
7070
const { refresh: refreshDetail } = result;
71-
useFocusEffect(() => refreshDetail());
71+
useFocusEffect(refreshDetail);
7272
const permissions = usePullRequestPermissions(params, result.data);
7373
const submission = useActionSubmission(params);
7474
const review = useAtomCommand(composerPullRequests.submitReview, { reportFailure: false });

‎apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ export function PullRequestRouteScreen({ route }: StaticScreenProps<PullRequestP
400400
const result = useEnvironmentQuery(detailAtom);
401401
const pullRefresh = usePullToRefresh(detailAtom);
402402
const { refresh: refreshDetail } = result;
403-
useFocusEffect(() => refreshDetail());
403+
useFocusEffect(refreshDetail);
404404
const pr = usePullRequestLiveChecks(params, result.data);
405405
const summary = params.initialSummary;
406406
const identity = pr ?? summary;
@@ -894,7 +894,7 @@ function PullRequestFileRouteContent({ route }: PullRequestFileRouteProps) {
894894
route.params.focus ? route.params.path : undefined,
895895
);
896896
const { refresh: refreshDetail } = detail;
897-
useFocusEffect(() => refreshDetail());
897+
useFocusEffect(refreshDetail);
898898
const { loadMore } = result;
899899
const parsed = filter.parsed;
900900
const reviewDraft = usePullRequestReviewDraft(route.params);
Lines changed: 190 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,190 @@
1+
import {
2+
NavigationContext,
3+
type NavigationProp,
4+
type ParamListBase,
5+
} from "@react-navigation/native";
6+
import { act } from "react";
7+
import { createRoot } from "react-dom/client";
8+
import { expect, it, vi } from "vite-plus/test";
9+
10+
const mocks = vi.hoisted(() => ({
11+
query: {
12+
data: null as { run: { _tag: "Running" | "Completed" } } | null,
13+
isPending: false,
14+
refresh: vi.fn<() => void>(),
15+
},
16+
otherQuery: {
17+
data: null as { run: { _tag: "Running" | "Completed" } } | null,
18+
isPending: false,
19+
refresh: vi.fn<() => void>(),
20+
},
21+
}));
22+
23+
vi.mock("@react-navigation/native", async () => {
24+
const { createRequire } = await import("node:module");
25+
const { realpathSync } = await import("node:fs");
26+
const require = createRequire(import.meta.url);
27+
const nativeRequire = createRequire(
28+
realpathSync(require.resolve("@react-navigation/native/package.json")),
29+
);
30+
// Use the shipped focus hook without importing the React Native view layer.
31+
const { NavigationContext, useFocusEffect }: typeof import("@react-navigation/native") =
32+
nativeRequire("@react-navigation/core");
33+
return { NavigationContext, useFocusEffect };
34+
});
35+
vi.mock("@effect/atom-react", () => ({
36+
useAtomValue: (atom: unknown) => (atom === "settings" ? { reviewGuidesEnabled: true } : true),
37+
}));
38+
vi.mock("../../../state/server", () => ({
39+
serverEnvironment: { settingsValueAtom: () => "settings" },
40+
}));
41+
vi.mock("../../../state/pull-requests", () => ({
42+
composerPullRequests: {
43+
reviewGuide: (target: { number: number; environmentId: string }) =>
44+
target.environmentId === "environment" && target.number === 1 ? 1 : 2,
45+
generateReviewGuide: { permissionAtom: () => "permission" },
46+
},
47+
}));
48+
vi.mock("../../../state/query", () => ({
49+
useEnvironmentQuery: (number: number) => ({ ...(number === 1 ? mocks.query : mocks.otherQuery) }),
50+
}));
51+
vi.mock("../../../state/use-atom-command", () => ({ useAtomCommand: () => vi.fn() }));
52+
vi.mock("../usePullRequestConnected", () => ({ usePullRequestConnected: () => true }));
53+
vi.mock("../usePullRequestDiff", () => ({
54+
pullRequestTarget: (params: unknown) => params,
55+
}));
56+
57+
import { useReviewGuide } from "./useReviewGuide";
58+
59+
function createNavigation() {
60+
const listeners = { focus: new Set<() => void>(), blur: new Set<() => void>() };
61+
let focused = true;
62+
return {
63+
value: {
64+
isFocused: () => focused,
65+
addListener: (event: keyof typeof listeners, listener: () => void) => {
66+
listeners[event].add(listener);
67+
return () => listeners[event].delete(listener);
68+
},
69+
} as unknown as NavigationProp<ParamListBase>,
70+
focus(next: boolean) {
71+
focused = next;
72+
act(() => {
73+
for (const listener of listeners[next ? "focus" : "blur"]) listener();
74+
});
75+
},
76+
};
77+
}
78+
79+
function setup() {
80+
(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
81+
mocks.query = { data: null, isPending: false, refresh: vi.fn() };
82+
mocks.otherQuery = { data: null, isPending: false, refresh: vi.fn() };
83+
const root = createRoot(document.createElement("div"));
84+
const navigation = createNavigation();
85+
const params = {
86+
environmentId: "environment",
87+
projectId: "project",
88+
repository: "repo",
89+
number: 1,
90+
};
91+
function Probe({ number, environmentId }: { number: number; environmentId: string }) {
92+
useReviewGuide({ ...params, number, environmentId });
93+
return null;
94+
}
95+
return {
96+
render(number = 1, environmentId = params.environmentId) {
97+
act(() =>
98+
root.render(
99+
<NavigationContext.Provider value={navigation.value}>
100+
<Probe number={number} environmentId={environmentId} />
101+
</NavigationContext.Provider>,
102+
),
103+
);
104+
},
105+
focus: navigation.focus,
106+
[Symbol.dispose]() {
107+
act(() => root.unmount());
108+
},
109+
};
110+
}
111+
112+
it("refreshes on focus and PR changes without refreshing again for query rerenders", () => {
113+
using screen = setup();
114+
screen.render();
115+
expect(mocks.query.refresh).toHaveBeenCalledTimes(1);
116+
117+
mocks.query = { ...mocks.query, isPending: true };
118+
screen.render();
119+
mocks.query = { ...mocks.query, isPending: false, data: { run: { _tag: "Completed" } } };
120+
screen.render();
121+
expect(mocks.query.refresh).toHaveBeenCalledTimes(1);
122+
123+
screen.focus(false);
124+
screen.render();
125+
expect(mocks.query.refresh).toHaveBeenCalledTimes(1);
126+
screen.focus(true);
127+
expect(mocks.query.refresh).toHaveBeenCalledTimes(2);
128+
129+
screen.render(2);
130+
expect(mocks.otherQuery.refresh).toHaveBeenCalledTimes(1);
131+
screen.render(2);
132+
expect(mocks.otherQuery.refresh).toHaveBeenCalledTimes(1);
133+
expect(mocks.query.refresh).toHaveBeenCalledTimes(2);
134+
});
135+
136+
it("preserves the polling deadline across rerenders and stops polling on blur or completion", () => {
137+
vi.useFakeTimers();
138+
using _timers = { [Symbol.dispose]: () => vi.useRealTimers() };
139+
using screen = setup();
140+
mocks.query.data = { run: { _tag: "Running" } };
141+
screen.render();
142+
expect(mocks.query.refresh).toHaveBeenCalledTimes(1);
143+
144+
act(() => vi.advanceTimersByTime(4_000));
145+
mocks.query = { ...mocks.query, isPending: true, data: { run: { _tag: "Running" } } };
146+
screen.render();
147+
expect(mocks.query.refresh).toHaveBeenCalledTimes(1);
148+
act(() => vi.advanceTimersByTime(1_000));
149+
expect(mocks.query.refresh).toHaveBeenCalledTimes(2);
150+
151+
screen.focus(false);
152+
act(() => vi.advanceTimersByTime(10_000));
153+
expect(mocks.query.refresh).toHaveBeenCalledTimes(2);
154+
screen.focus(true);
155+
expect(mocks.query.refresh).toHaveBeenCalledTimes(3);
156+
act(() => vi.advanceTimersByTime(5_000));
157+
expect(mocks.query.refresh).toHaveBeenCalledTimes(4);
158+
159+
mocks.query = { ...mocks.query, isPending: false, data: { run: { _tag: "Completed" } } };
160+
screen.render();
161+
const refreshesOnCompletion = mocks.query.refresh.mock.calls.length;
162+
act(() => vi.advanceTimersByTime(10_000));
163+
expect(mocks.query.refresh).toHaveBeenCalledTimes(refreshesOnCompletion);
164+
});
165+
166+
it("retires the old environment's polling on target change and clears polling on unmount", () => {
167+
vi.useFakeTimers();
168+
using _timers = { [Symbol.dispose]: () => vi.useRealTimers() };
169+
{
170+
using screen = setup();
171+
mocks.query.data = { run: { _tag: "Running" } };
172+
mocks.otherQuery.data = { run: { _tag: "Running" } };
173+
screen.render();
174+
act(() => vi.advanceTimersByTime(4_000));
175+
176+
screen.render(1, "other-environment");
177+
expect(mocks.query.refresh).toHaveBeenCalledTimes(1);
178+
expect(mocks.otherQuery.refresh).toHaveBeenCalledTimes(1);
179+
act(() => vi.advanceTimersByTime(1_000));
180+
expect(mocks.query.refresh).toHaveBeenCalledTimes(1);
181+
expect(mocks.otherQuery.refresh).toHaveBeenCalledTimes(1);
182+
act(() => vi.advanceTimersByTime(4_000));
183+
expect(mocks.query.refresh).toHaveBeenCalledTimes(1);
184+
expect(mocks.otherQuery.refresh).toHaveBeenCalledTimes(2);
185+
}
186+
act(() => vi.advanceTimersByTime(10_000));
187+
expect(mocks.query.refresh).toHaveBeenCalledTimes(1);
188+
expect(mocks.otherQuery.refresh).toHaveBeenCalledTimes(2);
189+
expect(vi.getTimerCount()).toBe(0);
190+
});

‎apps/mobile/vite.config.ts‎

Lines changed: 52 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
import { defineConfig } from "vite-plus";
1+
import * as NodeModule from "node:module";
2+
import * as NodeURL from "node:url";
3+
import { defineConfig, normalizePath } from "vite-plus";
24
import "vite-plus/test/config";
35

46
const reactTests = [
@@ -8,6 +10,7 @@ const reactTests = [
810
"src/features/diffs/nativeReviewDiffSurface.test.tsx",
911
"src/features/pull-requests/usePullRequestDiff.test.tsx",
1012
"src/components/ui/Dialog.android.test.tsx",
13+
"src/features/pull-requests/guide/useReviewGuide.test.tsx",
1114
"src/features/settings/SettingsServerControlsRouteScreen.test.tsx",
1215
"src/features/settings/components/BranchNamingSettings.test.tsx",
1316
"src/features/threads/ThreadMarkdownImage.test.tsx",
@@ -20,6 +23,16 @@ const reactTests = [
2023
"src/features/terminal/useTerminalExitNavigation.test.tsx",
2124
];
2225

26+
const sourceRoot = `${normalizePath(NodeURL.fileURLToPath(new URL("./src", import.meta.url)))}/`;
27+
const require = NodeModule.createRequire(import.meta.url);
28+
const babel: {
29+
transformAsync: (
30+
code: string,
31+
options: Record<string, unknown>,
32+
) => Promise<{ code?: string | null; map?: object | null } | null>;
33+
} = require("@babel/core");
34+
const babelConfig = require("./babel.config.js")({ cache: () => {} });
35+
2336
export default defineConfig({
2437
test: {
2538
hookTimeout: 60_000,
@@ -39,6 +52,44 @@ export default defineConfig({
3952
},
4053
{
4154
extends: true,
55+
plugins: [
56+
{
57+
name: "mobile-release-react-compiler",
58+
enforce: "pre",
59+
async transform(code, id) {
60+
if (
61+
!normalizePath(id).startsWith(sourceRoot) ||
62+
!/\.tsx?$/.test(id) ||
63+
/\.test\.tsx?$/.test(id)
64+
) {
65+
return;
66+
}
67+
const result = await babel.transformAsync(code, {
68+
...babelConfig,
69+
presets: babelConfig.presets.map(([name, options]: [string, object]) => [
70+
require.resolve(name),
71+
// Vite runs in Node; inline Babel helpers instead of Metro runtime imports.
72+
{ ...options, enableBabelRuntime: false },
73+
]),
74+
filename: id,
75+
babelrc: false,
76+
configFile: false,
77+
sourceMaps: true,
78+
caller: {
79+
name: "metro",
80+
bundler: "metro",
81+
platform: "ios",
82+
isDev: false,
83+
isServer: false,
84+
isNodeModule: false,
85+
supportsStaticESM: true,
86+
supportsReactCompiler: true,
87+
},
88+
});
89+
if (result?.code) return { code: result.code, map: result.map };
90+
},
91+
},
92+
],
4293
test: {
4394
name: "react",
4495
include: reactTests,

0 commit comments

Comments
 (0)