Skip to content

Commit 6d9ec7b

Browse files
only21milclaude
andauthored
fix(pi): stop blank input placeholders from failing the run (pingdotgg#23235)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent 56c365c commit 6d9ec7b

2 files changed

Lines changed: 39 additions & 1 deletion

File tree

‎packages/provider-pi/src/server/adapter.test.ts‎

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3126,6 +3126,40 @@ describe("PiAdapterV2", () => {
31263126
}).pipe(Effect.scoped, Effect.provide(layerTest)),
31273127
);
31283128

3129+
it.effect("asks an input dialog's title when its placeholder is blank", () =>
3130+
Effect.gen(function* () {
3131+
const fake = yield* makeFakePi;
3132+
const { runtime, takeEvent } = yield* openRuntime(fake);
3133+
yield* runtime.ensureThread({
3134+
threadId: THREAD_ID,
3135+
modelSelection: modelSelection("default"),
3136+
runtimePolicy,
3137+
});
3138+
const title = "Which database?\n1. Postgres\n2. Type something.\nType your answer:";
3139+
yield* fake.emit({
3140+
type: "extension_ui_request",
3141+
id: "ui-input",
3142+
method: "input",
3143+
title,
3144+
placeholder: "",
3145+
});
3146+
const event = yield* takeEvent(
3147+
(event) =>
3148+
event.type === "turn_item.updated" && event.turnItem.type === "user_input_request",
3149+
);
3150+
if (event.type !== "turn_item.updated" || event.turnItem.type !== "user_input_request") {
3151+
return assert.fail("expected a user input request");
3152+
}
3153+
assert.equal(decodeUserInputQuestions(event.turnItem.questions)[0]?.question, title);
3154+
yield* runtime.respondToRuntimeRequest({
3155+
requestId: event.turnItem.requestId,
3156+
answers: { "ui-input": "SQLite" },
3157+
});
3158+
const response = yield* fake.takeRequest("extension_ui_response");
3159+
assert.equal(response["value"], "SQLite");
3160+
}).pipe(Effect.scoped, Effect.provide(layerTest)),
3161+
);
3162+
31293163
it.effect("keeps the complete editor prefill editable and returns exact edited text", () =>
31303164
Effect.gen(function* () {
31313165
const fake = yield* makeFakePi;

‎packages/provider-pi/src/server/adapter.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3322,7 +3322,11 @@ function piQuestion(
33223322
value: "",
33233323
},
33243324
];
3325-
const question = recordString(event, "message") ?? recordString(event, "placeholder") ?? title;
3325+
// Extensions may send a blank placeholder, which is not a valid question.
3326+
const question =
3327+
[recordString(event, "message"), recordString(event, "placeholder")].find(
3328+
(text) => text !== undefined && text.trim().length > 0,
3329+
) ?? title;
33263330
return {
33273331
id: questionId,
33283332
header: title,

0 commit comments

Comments
 (0)