Skip to content

Commit 53830d4

Browse files
perf(mobile): isolate iOS Live Activity imports (pingdotgg#12380)
1 parent e0649ed commit 53830d4

4 files changed

Lines changed: 35 additions & 12 deletions

File tree

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import AgentActivity, { type AgentActivityProps } from "../../widgets/AgentActivity";
2+
3+
export function getAgentLiveActivities() {
4+
return AgentActivity.getInstances();
5+
}
6+
7+
export function startAgentLiveActivity(props: AgentActivityProps) {
8+
return AgentActivity.start(props);
9+
}
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import type { LiveActivity } from "expo-widgets";
2+
import type { AgentActivityProps } from "../../widgets/AgentActivity";
3+
4+
export function getAgentLiveActivities(): Array<LiveActivity<AgentActivityProps>> {
5+
return [];
6+
}
7+
8+
export function startAgentLiveActivity(
9+
_props: AgentActivityProps,
10+
): LiveActivity<AgentActivityProps> | null {
11+
return null;
12+
}

‎apps/mobile/src/features/agent-awareness/remoteRegistration.test.ts‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,9 @@ vi.mock("expo-widgets", () => ({
101101
addPushToStartTokenListener: vi.fn(() => ({ remove: vi.fn() })),
102102
}));
103103

104-
vi.mock("../../widgets/AgentActivity", () => ({
105-
default: {
106-
getInstances: widgetMocks.getInstances,
107-
start: widgetMocks.start,
108-
},
104+
vi.mock("./agentLiveActivity", () => ({
105+
getAgentLiveActivities: widgetMocks.getInstances,
106+
startAgentLiveActivity: widgetMocks.start,
109107
}));
110108

111109
// The state modules pull the whole connection stack (and native expo modules)

‎apps/mobile/src/features/agent-awareness/remoteRegistration.ts‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ import {
3535
loadPreferences,
3636
saveAgentAwarenessRegistrationRecord,
3737
} from "../../persistence/imperative";
38-
import AgentActivity, { type AgentActivityProps } from "../../widgets/AgentActivity";
38+
import type { AgentActivityProps } from "../../widgets/AgentActivity";
39+
import { getAgentLiveActivities, startAgentLiveActivity } from "./agentLiveActivity";
3940
import { resolveCloudPublicConfig } from "../cloud/publicConfig";
4041
import { supportsAgentAwarenessPush } from "./capabilities";
4142
import { makeRelayDeviceRegistrationRequest, resolveApsEnvironment } from "./registrationPayload";
@@ -522,11 +523,11 @@ function armAgentAwarenessLiveActivityForLocalWorkNow(input: {
522523
readonly projectTitle: string;
523524
}): void {
524525
try {
525-
if (AgentActivity.getInstances().length > 0) {
526+
if (getAgentLiveActivities().length > 0) {
526527
return;
527528
}
528529
const nowIso = new Date(Date.now()).toISOString();
529-
const activity = AgentActivity.start({
530+
const activity = startAgentLiveActivity({
530531
title: "T3 Code",
531532
subtitle: "Agent work in progress",
532533
activeCount: 1,
@@ -545,6 +546,9 @@ function armAgentAwarenessLiveActivityForLocalWorkNow(input: {
545546
},
546547
],
547548
});
549+
if (!activity) {
550+
return;
551+
}
548552
logRegistrationDebug("live activity card armed for local work", {
549553
threadTitle: input.threadTitle,
550554
});
@@ -842,7 +846,7 @@ function endLocalLiveActivities(context: string): void {
842846
return;
843847
}
844848
try {
845-
for (const activity of AgentActivity.getInstances()) {
849+
for (const activity of getAgentLiveActivities()) {
846850
activity.end("immediate").catch((error: unknown) => {
847851
logRegistrationError(context, error);
848852
});
@@ -1069,7 +1073,7 @@ export function refreshActiveLiveActivityRemoteRegistration(): Effect.Effect<
10691073
}
10701074

10711075
let activities = yield* Effect.try({
1072-
try: () => AgentActivity.getInstances(),
1076+
try: () => getAgentLiveActivities(),
10731077
catch: (cause) =>
10741078
new AgentAwarenessOperationError({
10751079
operation: "list-active-live-activities",
@@ -1118,7 +1122,7 @@ export function refreshActiveLiveActivityRemoteRegistration(): Effect.Effect<
11181122
// The snapshot request yields; an arm-on-send may have created the
11191123
// card in the meantime. Re-check so two cards are never started.
11201124
const armedMeanwhile = yield* Effect.try({
1121-
try: () => AgentActivity.getInstances(),
1125+
try: () => getAgentLiveActivities(),
11221126
catch: () => [] as ReadonlyArray<LiveActivity<AgentActivityProps>>,
11231127
}).pipe(Effect.orElseSucceed(() => [] as ReadonlyArray<LiveActivity<AgentActivityProps>>));
11241128
if (armedMeanwhile.length > 0) {
@@ -1127,7 +1131,7 @@ export function refreshActiveLiveActivityRemoteRegistration(): Effect.Effect<
11271131
const aggregate = snapshot.aggregate;
11281132
const primed = yield* Effect.try({
11291133
try: () =>
1130-
AgentActivity.start({
1134+
startAgentLiveActivity({
11311135
title: aggregate.title,
11321136
subtitle: aggregate.subtitle,
11331137
activeCount: aggregate.activeCount,

0 commit comments

Comments
 (0)