Skip to content

Commit 5349ecb

Browse files
saphidclaude
andauthored
fix(gitcafe): PR link previews show a GitHub-merged pull request as merged (pingdotgg#29595)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent efcb937 commit 5349ecb

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

‎packages/source-control-gitcafe/src/server/GitCafePullRequestProvider.test.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1103,6 +1103,8 @@ describe("GitCafePullRequestProvider", () => {
11031103
const detail = yield* provider.getChangeRequest(target);
11041104
assert.strictEqual(detail.state, "merged");
11051105
assert.strictEqual(detail.mergedAt, mergedAt);
1106+
const preview = yield* provider.getChangeRequestPreview!(target);
1107+
assert.strictEqual(preview.state, "merged");
11061108
}).pipe(Effect.provide(server.layer));
11071109
});
11081110

‎packages/source-control-gitcafe/src/server/GitCafePullRequestProvider.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -897,7 +897,7 @@ export const make = Effect.gen(function* () {
897897
),
898898
getChangeRequestPreview: (input) =>
899899
readPull("getChangeRequestPreview", input).pipe(
900-
Effect.map((pull) => Json.toChangeRequest(pull, input)),
900+
Effect.map((pull) => ({ ...Json.toChangeRequest(pull, input), ...settledMerge(pull) })),
901901
),
902902
getChangeRequestSummary: Effect.fn("GitCafePullRequestProvider.getChangeRequestSummary")(
903903
function* (input) {

0 commit comments

Comments
 (0)