Skip to content

Commit 2d11196

Browse files
t3dotggclaude
andauthored
revert: "fix(web): pinned thread marker stays put when hovering the row" (pingdotgg#11122) (pingdotgg#22223)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent 41b513d commit 2d11196

1 file changed

Lines changed: 9 additions & 11 deletions

File tree

‎apps/web/src/components/Sidebar.tsx‎

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2213,7 +2213,7 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
22132213
onPointerDown={handleActionPointerDown}
22142214
className={cn(
22152215
"pointer-events-none absolute inset-y-0 right-0 -mr-1 inline-flex cursor-pointer items-center gap-1 rounded-md bg-transparent px-1.5 text-xs text-muted-foreground opacity-0 transition-opacity hover:text-foreground focus-visible:pointer-events-auto focus-visible:opacity-100 group-any-hover/sidebar-row:pointer-events-auto group-any-hover/sidebar-row:opacity-100",
2216-
isWoke && "static",
2216+
isWoke && "group-any-hover/sidebar-row:static",
22172217
)}
22182218
>
22192219
<AlarmClockOffIcon className="mb-px size-3" />
@@ -2230,7 +2230,7 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
22302230
onPointerDown={handleActionPointerDown}
22312231
className={cn(
22322232
"pointer-events-none absolute inset-y-0 right-0 -mr-1 inline-flex cursor-pointer items-center gap-1 rounded-md bg-transparent px-1.5 text-xs text-muted-foreground opacity-0 transition-opacity hover:text-foreground focus-visible:pointer-events-auto focus-visible:opacity-100 group-any-hover/sidebar-row:pointer-events-auto group-any-hover/sidebar-row:opacity-100",
2233-
isWoke && "static",
2233+
isWoke && "group-any-hover/sidebar-row:static",
22342234
)}
22352235
/>
22362236
}
@@ -2247,7 +2247,7 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
22472247
onPointerDown={handleActionPointerDown}
22482248
className={cn(
22492249
"pointer-events-none absolute inset-y-0 right-0 inline-flex cursor-pointer items-center gap-1 rounded-md bg-transparent px-2 text-xs text-muted-foreground opacity-0 transition-opacity hover:text-foreground focus-visible:pointer-events-auto focus-visible:opacity-100 group-any-hover/sidebar-row:pointer-events-auto group-any-hover/sidebar-row:opacity-100",
2250-
isWoke && "static",
2250+
isWoke && "group-any-hover/sidebar-row:static",
22512251
)}
22522252
>
22532253
<CheckIcon className="size-3" />
@@ -2315,23 +2315,22 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
23152315
<span className="flex-1" />
23162316
)}
23172317
{pinIndicator}
2318-
{/* Reserve both states' widths so revealing actions cannot move the pin or Woke label. */}
23192318
{sortable?.isDragging ? (
23202319
dragDestination
23212320
) : (
23222321
<span
23232322
className={cn(
2324-
"group/sidebar-status-slot ml-auto grid h-5 min-w-8 shrink-0 items-stretch justify-end text-xs",
2323+
"group/sidebar-status-slot relative ml-auto flex h-5 min-w-8 shrink-0 items-stretch justify-end text-xs",
23252324
props.sweepAction !== null && "hidden",
23262325
)}
23272326
>
23282327
<span
23292328
className={cn(
23302329
isWokeStatus
23312330
? "pointer-events-auto"
2332-
: "pointer-events-none group-has-[:focus-visible]/sidebar-status-slot:opacity-0 group-any-hover/sidebar-row:opacity-0",
2333-
"flex items-center self-center justify-self-end tabular-nums text-secondary-label transition-opacity [grid-area:1/1]",
2334-
snoozeMenuOpen && "pointer-events-none opacity-0",
2331+
: "pointer-events-none group-has-[:focus-visible]/sidebar-status-slot:absolute group-has-[:focus-visible]/sidebar-status-slot:right-0 group-has-[:focus-visible]/sidebar-status-slot:opacity-0 group-any-hover/sidebar-row:absolute group-any-hover/sidebar-row:right-0 group-any-hover/sidebar-row:opacity-0",
2332+
"flex items-center self-center justify-self-end tabular-nums text-secondary-label transition-opacity",
2333+
snoozeMenuOpen && "pointer-events-none absolute right-0 opacity-0",
23352334
)}
23362335
>
23372336
{topStatus ? (
@@ -2402,9 +2401,8 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
24022401
// would keep the controls pinned over the status label
24032402
// once the pointer moves away (e.g. after a failed
24042403
// settle) instead of cross-fading back.
2405-
"pointer-events-none flex items-stretch justify-self-end opacity-0 transition-opacity has-[:focus-visible]:pointer-events-auto has-[:focus-visible]:opacity-100 group-any-hover/sidebar-row:pointer-events-auto group-any-hover/sidebar-row:opacity-100",
2406-
isWokeStatus ? "[grid-area:1/2]" : "[grid-area:1/1]",
2407-
snoozeMenuOpen && "pointer-events-auto opacity-100",
2404+
"pointer-events-none absolute inset-y-0 right-0 flex items-stretch opacity-0 transition-opacity has-[:focus-visible]:pointer-events-auto has-[:focus-visible]:static has-[:focus-visible]:opacity-100 group-any-hover/sidebar-row:pointer-events-auto group-any-hover/sidebar-row:static group-any-hover/sidebar-row:opacity-100",
2405+
snoozeMenuOpen && "pointer-events-auto static opacity-100",
24082406
)}
24092407
>
24102408
{hasUnsentDraft ? (

0 commit comments

Comments
 (0)