Skip to content

Commit 15c6e6b

Browse files
chore(lint): enforce unicorn/no-useless-fallback-in-spread (pingdotgg#25103)
1 parent 10d800c commit 15c6e6b

5 files changed

Lines changed: 7 additions & 6 deletions

File tree

‎apps/mobile/src/state/use-composer-drafts.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -995,7 +995,7 @@ export function ensureComposerDraftsLoaded(): void {
995995
...Object.fromEntries(
996996
Object.entries(current).map(([instanceId, models]) => [
997997
instanceId,
998-
{ ...(persisted.modelOptionMemory[instanceId] ?? {}), ...models },
998+
{ ...persisted.modelOptionMemory[instanceId], ...models },
999999
]),
10001000
),
10011001
});

‎apps/mobile/src/state/use-model-option-memory.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function recordModelOptionsInState(
1818
return {
1919
...state,
2020
[instanceId]: {
21-
...(state[instanceId] ?? {}),
21+
...state[instanceId],
2222
[model]: options,
2323
},
2424
};

‎packages/shared/src/serverSettings.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ function translateLegacyProjectOverridePatch(
330330
for (const [projectId, value] of Object.entries(map)) {
331331
if (canonicalProjectIds.has(projectId)) continue;
332332
const entry: ProjectSettingsOverrides = {
333-
...(entries.get(projectId) ?? currentEntries[projectId] ?? {}),
333+
...(entries.get(projectId) ?? currentEntries[projectId]),
334334
};
335335
if (value === null || value === undefined) {
336336
delete entry[key];

‎scripts/lib/cli-external-packages.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,9 @@ it.layer(NodeServices.layer)("external package dependency closure", (it) => {
101101
if (!manifest) continue;
102102

103103
const declared = {
104-
...(manifest.dependencies ?? {}),
105-
...(manifest.optionalDependencies ?? {}),
106-
...(manifest.peerDependencies ?? {}),
104+
...manifest.dependencies,
105+
...manifest.optionalDependencies,
106+
...manifest.peerDependencies,
107107
};
108108
for (const dependency of Object.keys(declared)) {
109109
if (!isRuntimeExternal(dependency)) {

‎vite.config.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ export default defineConfig({
216216
perf: "warn",
217217
},
218218
rules: {
219+
"unicorn/no-useless-fallback-in-spread": "error",
219220
"unicorn/require-module-specifiers": "error",
220221
"unicorn/no-array-sort": "off",
221222
"unicorn/consistent-function-scoping": "off",

0 commit comments

Comments
 (0)