is_saved_the_key()からauto-draft判定を削除#113
Merged
inc2734 merged 1 commit intoinc2734:masterfrom Nov 19, 2025
Merged
Conversation
Owner
|
理由はもう覚えていないのですが、ご指摘どおりな気がするのでマージします! |
Contributor
Author
|
ありがとうございます! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
is_saved_the_key()メソッドから、auto-draft状態の投稿に対する早期リターン判定を削除しました。変更理由
現在の実装では、投稿ステータスが
auto-draftの場合、メタデータの存在に関わらず常にfalseを返していました。しかし、auto-draft状態でメタデータを保存するプラグインが存在します。たとえば、Polylangプラグインは、投稿の複製時にauto-draft状態で本文やメタデータを引き継ぐ実装を行っています。メタデータ存在確認のクエリを節約できるという理由以外に、
auto-draftチェックを入れる理由が思い当たらなかったため、常に存在確認するように変更しました。変更内容
auto-draftステータスのチェックを削除テスト方法