Accept and handle emails sent with an empty 821.From / return-path as…#561
Merged
jhillyerd merged 2 commits intoinbucket:mainfrom Mar 17, 2025
Merged
Accept and handle emails sent with an empty 821.From / return-path as…#561jhillyerd merged 2 commits intoinbucket:mainfrom
jhillyerd merged 2 commits intoinbucket:mainfrom
Conversation
… it would any other email. Signed-off-by: Steve Atkins <[email protected]>
Pull Request Test Coverage Report for Build 13898407630Details
💛 - Coveralls |
jhillyerd
requested changes
Mar 16, 2025
Signed-off-by: Steve Atkins <[email protected]>
jhillyerd
approved these changes
Mar 17, 2025
gregorwolf
pushed a commit
to gregorwolf/inbucket
that referenced
this pull request
Apr 8, 2025
inbucket#561) * Accept and handle emails sent with an empty 821.From / return-path as it would any other email.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept and handle emails sent with an empty 821.From / return-path as it would any other email.
Passes unit tests.
Manual testing via the web UI after delivering mails with an empty 821.From, both with and without a 5322 From: header shows no problems.
Inbucket doesn't display the 821.From in the UI, so previous concerns about an empty field breaking the UI aren't an issue, so the previous code that replaced an empty 821.From with the string "unassigned" have been removed (and they've not had any effect for years)
Closes #558.