Skip to content

fix(pop3): Prevent STLS cmd triggered crashes#516

Merged
jhillyerd merged 2 commits intomainfrom
515-inbucket-unit-exited-after-wrn-wasnt-expecting-stls-here-module=pop3
Jun 13, 2024
Merged

fix(pop3): Prevent STLS cmd triggered crashes#516
jhillyerd merged 2 commits intomainfrom
515-inbucket-unit-exited-after-wrn-wasnt-expecting-stls-here-module=pop3

Conversation

@jhillyerd
Copy link
Copy Markdown
Collaborator

@jhillyerd jhillyerd commented Jun 13, 2024

Signed-off-by: James Hillyerd [email protected]

@jhillyerd jhillyerd linked an issue Jun 13, 2024 that may be closed by this pull request
inbucket unit exited after WRN Wasn't expecting STLS here module=pop3 #515
Closed
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9505219824

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 56.202%
Files with Coverage Reduction New Missed Lines %
pkg/server/pop3/handler.go 10 26.88%
Totals Coverage Status
Change from base Build 9073603067: 0.4%
Covered Lines: 2705
Relevant Lines: 4813
💛 - Coveralls

@jhillyerd jhillyerd force-pushed the 515-inbucket-unit-exited-after-wrn-wasnt-expecting-stls-here-module=pop3 branch from fc90a05 to ec2c057 Compare June 13, 2024 19:22
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9505562586

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 56.202%
Files with Coverage Reduction New Missed Lines %
pkg/server/pop3/handler.go 10 26.88%
Totals Coverage Status
Change from base Build 9505558273: 0.4%
Covered Lines: 2705
Relevant Lines: 4813
💛 - Coveralls

@jhillyerd
err lint fix
9fd73a6 
Signed-off-by: James Hillyerd <[email protected]>
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9505663172

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 56.202%
Files with Coverage Reduction New Missed Lines %
pkg/server/pop3/handler.go 10 26.88%
Totals Coverage Status
Change from base Build 9505558273: 0.4%
Covered Lines: 2705
Relevant Lines: 4813
💛 - Coveralls

@jhillyerd jhillyerd merged commit b16764a into main Jun 13, 2024
@jhillyerd jhillyerd deleted the 515-inbucket-unit-exited-after-wrn-wasnt-expecting-stls-here-module=pop3 branch June 13, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

inbucket unit exited after WRN Wasn't expecting STLS here module=pop3

2 participants

@jhillyerd @coveralls