[Rest Client] changing to enable relative urls#477
Merged
jhillyerd merged 2 commits intoinbucket:mainfrom Feb 9, 2024
Merged
Conversation
Signed-off-by: Corey Aloia <[email protected]>
Pull Request Test Coverage Report for Build 7843333401
💛 - Coveralls |
jhillyerd
reviewed
Feb 9, 2024
Signed-off-by: Corey Aloia <[email protected]>
corey-aloia
force-pushed
the
rest-client-base-url
branch
from
c1d6263 to
680903d
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #476
I have done this globally, but potentially it could be better to have an option when creating the rest client to decide. But when creating the client, we base the "base" url, which to me means it can be more than schema and hostname.
Let me know what you think!