Skip to content

storage test: fix failures on windows#457

Merged
jhillyerd merged 2 commits intomainfrom
win-fstore-test
Dec 13, 2023
Merged

storage test: fix failures on windows#457
jhillyerd merged 2 commits intomainfrom
win-fstore-test

Conversation

@jhillyerd
Copy link
Copy Markdown
Collaborator

@jhillyerd jhillyerd commented Dec 13, 2023 •
edited
Loading

Some file handles were not being closed. I also made some of the tests more readable.

For #450

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7190130521

  • 3 of 22 (13.64%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 55.331%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/test/storage_suite.go 0 19 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/test/storage_suite.go 1 0.0%
Totals Coverage Status
Change from base Build 7055495273: 0.07%
Covered Lines: 2631
Relevant Lines: 4755
💛 - Coveralls

@jhillyerd jhillyerd marked this pull request as ready for review December 13, 2023 03:07
@jhillyerd jhillyerd merged commit 5a5864f into main Dec 13, 2023
@jhillyerd jhillyerd deleted the win-fstore-test branch December 13, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jhillyerd @coveralls