Skip to content

storage: $ can be used in place of : in filestore path#449

Merged
jhillyerd merged 1 commit intomainfrom
399-cannot-set-inbucket_storage_params=pathdanything-causes-error
Dec 1, 2023
Merged

storage: $ can be used in place of : in filestore path#449
jhillyerd merged 1 commit intomainfrom
399-cannot-set-inbucket_storage_params=pathdanything-causes-error

Conversation

@jhillyerd
Copy link
Copy Markdown
Collaborator

Signed-off-by: James Hillyerd [email protected]

@jhillyerd jhillyerd linked an issue Nov 29, 2023 that may be closed by this pull request
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 29, 2023

Pull Request Test Coverage Report for Build 7055333839

  • 8 of 12 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 55.257%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/storage/file/fstore.go 8 12 66.67%
Totals Coverage Status
Change from base Build 7053435162: 0.1%
Covered Lines: 2628
Relevant Lines: 4756

💛 - Coveralls

@jhillyerd jhillyerd force-pushed the 399-cannot-set-inbucket_storage_params=pathdanything-causes-error branch 4 times, most recently from 648d815 to 4459f80 Compare November 30, 2023 23:29
@jhillyerd jhillyerd force-pushed the 399-cannot-set-inbucket_storage_params=pathdanything-causes-error branch from 4459f80 to 11c1ef1 Compare December 1, 2023 03:20
@jhillyerd jhillyerd merged commit e6e4e09 into main Dec 1, 2023
@jhillyerd jhillyerd deleted the 399-cannot-set-inbucket_storage_params=pathdanything-causes-error branch December 1, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot set INBUCKET_STORAGE_PARAMS=path:D:\anything causes error

2 participants