Implement STLS for pop3.#384
Merged
Conversation
added 3 commits
August 30, 2023 07:23
Signed-off-by: Benson Margulies <[email protected]>
Signed-off-by: Benson Margulies <[email protected]>
Signed-off-by: Benson Margulies <[email protected]>
Collaborator
|
Let me know when this one is ready to be reviewed, looks like you may still be adding to it. |
Author
|
It's done now.
…On Wed, Aug 30, 2023 at 7:31 PM James Hillyerd ***@***.***> wrote:
Let me know when this one is ready to be reviewed, looks like you may
still be adding to it.
—
Reply to this email directly, view it on GitHub
<#384 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7SDZPXWV5D7D2LIE72PMLXX7ZRVANCNFSM6AAAAAA4EWU6V4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
jhillyerd
requested changes
Aug 31, 2023
Collaborator
jhillyerd
left a comment
jhillyerd
left a comment
There was a problem hiding this comment.
Thanks for adding this, I'm pretty sure the POP3 server is the oldest and most crufty code in the whole project.
Signed-off-by: Benson Margulies <[email protected]>
Author
|
This should be ready now, I added another commit with the repair. |
jhillyerd
approved these changes
Sep 5, 2023
Collaborator
|
Excellent, thank you! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the STLS command for POP3.