Skip to content

Add arm and arm64 builds#256

Merged
jhillyerd merged 2 commits intoinbucket:mainfrom
danielsimkus:patch-1
Jan 22, 2022
Merged

Add arm and arm64 builds#256
jhillyerd merged 2 commits intoinbucket:mainfrom
danielsimkus:patch-1

Conversation

@danielsimkus
Copy link
Copy Markdown
Contributor

Re: #246

👋 This should start building ARM and ARM64 builds. I'm not familiar with goreleaser myself but this seems to follow their example in the docs https://goreleaser.com/customization/build/

Signed-off-by: danielsimkus <[email protected]>
@jhillyerd
Copy link
Copy Markdown
Collaborator

jhillyerd commented Jan 21, 2022

Looks like you need to add this for inbucket-client as well, lower in the file: release failed after 188.48s error=invalid archive: 0: archive has different count of built binaries for each platform, which may cause your users confusion. Please make sure all builds used have the same set of goos/goarch/etc or split it into multiple archives

@jhillyerd jhillyerd self-requested a review January 21, 2022 21:01
@danielsimkus
Copy link
Copy Markdown
Contributor Author

Ah that makes sense, will add that and also goarm 7 perhaps?

@danielsimkus
Copy link
Copy Markdown
Contributor Author

Re discussions in #246 switched goarm to just 7.
Also one thing to note, not sure if it's an issue but the syntax checker on the gorelease.yml forced a string type for goarm, but in their documentation they use integers: https://goreleaser.com/customization/build/

Not sure if it actually matters though

@jhillyerd
Copy link
Copy Markdown
Collaborator

Nothing matters with yaml, it's all garbage. :) I can see arm7 labels on the output files, so I think it works. I think there are some more security fixes I need to merge, then I will cut another release candidate. Thanks!

@jhillyerd jhillyerd merged commit 5def9ed into inbucket:main Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants