Apply JSHint and JSCS with jQuery configs#535
Merged
FagnerMartinsBrack merged 4 commits intoimpress:masterfrom Apr 16, 2016
FagnerMartinsBrack:code-style
Merged
Apply JSHint and JSCS with jQuery configs#535FagnerMartinsBrack merged 4 commits intoimpress:masterfrom FagnerMartinsBrack:code-style
FagnerMartinsBrack merged 4 commits intoimpress:masterfrom
FagnerMartinsBrack:code-style
Conversation
We only remove one option from .jshintrc, which is the 'node: true'. This project does not uses node and therefore it doesn't makes sense keeping an option like that'
We don't have a CI yet, so the check should be done manually
This was referenced Mar 19, 2016
Closed
Member
Author
|
I have edited to add the actual link for review without whitespace changes: https://github.com/impress/impress.js/compare/master...FagnerMartinsBrack:code-style?w=1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configs were retrieved from the jQuery master branch at the moment this PR was started.
For detailed information on jQuery core style guidelines, see: https://contribute.jquery.org/style-guide/js/
To review, please put
?w=1in the URL bar in the browser so that Github ignore all whitespace-only changes. Here is the link.This closes #529 and (when 0.6.0 is finished) it will also close #426, because then we will have a proper
package.jsonto be able to publish the project on npm.@impress/mergers