Skip to content

[Doc] Added license, updated Readme and added Changelog file#511

Merged
bartaz merged 3 commits intoimpress:masterfrom
Pierstoval:license_doc
Feb 3, 2016
Merged

[Doc] Added license, updated Readme and added Changelog file#511
bartaz merged 3 commits intoimpress:masterfrom
Pierstoval:license_doc

Conversation

@Pierstoval
Copy link
Copy Markdown
Contributor

@Pierstoval Pierstoval commented Feb 2, 2016

Ping @impress/mergers for review

@bartaz bartaz mentioned this pull request Feb 2, 2016
Closed
@Pierstoval
Copy link
Copy Markdown
Contributor Author

Pierstoval commented Feb 2, 2016

@bartaz I made fb0f882 to fix your comments. Could you reply only in the PR ("Files changed" tab, and not the commit itself) to keep the diff/notes up to date to your needs? :)

@bartaz
Copy link
Copy Markdown
Member

bartaz commented Feb 2, 2016

@Pierstoval sure, I wasn't aware that these comments are not shared across commit and files changed pages. They still appear there in PR thread.

bartaz
bartaz reviewed Feb 2, 2016
View reviewed changes
README.md Outdated
Copy link
Copy Markdown
Member

@bartaz bartaz Feb 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the fixes. Still, make clear that license is MIT in readme, so people don't need to look into license file just to know that. So make it Released under the MIT [License](LICENSE). - note the typo in file name.

Copy link
Copy Markdown
Contributor Author

@Pierstoval Pierstoval Feb 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a33f2ec !

@FagnerMartinsBrack
Copy link
Copy Markdown
Member

FagnerMartinsBrack commented Feb 2, 2016

The good thing in comment on the "Files Changed" tab is that Github shows a part of the snippet and all comments below it in the timeline

@Pierstoval
Copy link
Copy Markdown
Contributor Author

Pierstoval commented Feb 2, 2016

The good thing in comment on the "Files Changed" tab is that Github shows a part of the snippet and all comments below it in the timeline

And when a line of code is changed, the note appears as outdated diff instead of a global note 😉

bartaz added a commit that referenced this pull request Feb 3, 2016
@bartaz
Merge pull request #511 from Pierstoval/license_doc
d277f54 
Cleaning up the docs - Added license, updated Readme and added Changelog file
@bartaz bartaz merged commit d277f54 into impress:master Feb 3, 2016
@Pierstoval Pierstoval deleted the license_doc branch February 3, 2016 07:44
@FagnerMartinsBrack FagnerMartinsBrack mentioned this pull request Feb 3, 2016
Closed
@FagnerMartinsBrack FagnerMartinsBrack mentioned this pull request Feb 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pierstoval @bartaz @FagnerMartinsBrack