-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Code style decision #529
Copy link
Copy link
Closed
Description
In this issue we should discuss how we are going to handle code style.
This is not for a discussion of "spaces vs tabs" or "semicolon or not", this assumes that the value on code style lies in the consistency, so there are some alternatives here:
- Pick whatever standard is most used in the codebase right now and stick to it, later using an automated tool like JSCS if we want to automate it (for now we try to fix in code review until we automate it). If a standard cannot be infered by the
impress.jsfile orindex.htmlfile, then we can just choose one. - Use a code style that already exists (airbnb, standard, semistandard, jquery core style, etc.)
Proposal 1 will take more time, but the team will be more comfortable. Proposal 2 prevents unnecessary bikeshedding, but the team might be a little uncomfortable.
So, should we use proposal 1 or proposal 2. Do you have another proposal?
@impress/mergers
Reactions are currently unavailable