[New] no-unused-modules: add eslint v8 support#2194
Merged
ljharb merged 1 commit intoimport-js:mainfrom Aug 26, 2021
Merged
Conversation
ljharb
reviewed
Aug 17, 2021
Contributor
Author
|
Let's use try-catch it is very popular, make codebase flat and similar concept with tuples has Go, a lot people interested in such version, and it can became standard in the future. Nesting you suggest me to add is horrible and not maintainable. |
ljharb
requested changes
Aug 18, 2021
ljharb
changed the title
no-unused-modules: add eslint v8 support
ljharb
approved these changes
Aug 26, 2021
ljharb
approved these changes
Aug 26, 2021
Contributor
|
Any chance of a release of this? While it might still give peer dep warnings etc until "proper" v8 support lands, I believe this should unblock modules using this plugin in their own migration work without resorting to patching the module 🙂 |
Member
|
I'll try to make a pass through the open PRs and issues this weekend and see if I can cut a release. |
Contributor
|
v8 is released, a release of this PR would be awesome 🙂 |
Member
|
Yep, planning on it very soon. |
This was referenced Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support of ESLint v8, the
/libentry point has removed, andshould be changed to
Here is how it looks like in v8 right now
Related to typescript-eslint/typescript-eslint#3735 and typescript-eslint/typescript-eslint#3737 (comment)