Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes reversed indexed iteration for lazy sequences with unknown sizes.
Changes:
- Uses the materialized collection size when generating reverse indices.
- Adds regression coverage for iteration APIs.
- Modifies native SWC lockfile platform metadata.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Operations.js |
Corrects reverse-index calculation. |
__tests__/IndexedSeq.ts |
Tests lazy reversed sequence behavior. |
package-lock.json |
Removes SWC libc constraints. |
Suppressed comments (1)
src/Operations.js:318
- This comment is inaccurate: the forward branch does use
i++as the emitted index; only the materializedsizeis unnecessary. Reword it to describe why size calculation is skipped.
// ignore when not reversed, since the index is not used in that case.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a lazy seq of unknown size, reversed indexed iteration used to produce NaN keys.
Use
ensureSizereturn value with the the reversed sequence (the existingensureSize(collection)guard fixes the wrong object's size).