c2rust-ast-exporter: fix segfault from iterator invalidation#897
Merged
kkysen merged 1 commit intoimmunant:masterfrom Apr 24, 2023
maribu:c2rust-ast-export/fix_segfault
Merged
c2rust-ast-exporter: fix segfault from iterator invalidation#897kkysen merged 1 commit intoimmunant:masterfrom maribu:c2rust-ast-export/fix_segfault
c2rust-ast-exporter: fix segfault from iterator invalidation#897kkysen merged 1 commit intoimmunant:masterfrom
maribu:c2rust-ast-export/fix_segfault
Conversation
Using an iterator to iterate over an vector while modifying the underlying vector is invalid. This caused an segfault for a specific input, which is fixed by using operator[] for accessing the vector members instead.
kkysen
approved these changes
Apr 24, 2023
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
Thanks for hunting this down! Looks like it was a difficult bug in RIOT-OS/RIOT#19495, though at least the fix is quite simple.
kkysen
changed the title
c2rust-ast-exporter: fix segfault from iterator invalidation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using an iterator to iterate over an vector while modifying the underlying vector is invalid. This caused an segfault for a specific input, which is fixed by using operator[] for accessing the vector members instead.