transpile: use core::ffi::c_* instead of std::ffi::c_*#1381
Merged
Conversation
kkysen
force-pushed
the
kkysen/use-core-for-ffi-types
branch
from
38ec7b1 to
3dc0c87
Compare
kkysen
force-pushed
the
kkysen/use-core-for-ffi-types
branch
from
3dc0c87 to
76f39c1
Compare
fw-immunant
approved these changes
Sep 29, 2025
Contributor
fw-immunant
left a comment
fw-immunant
left a comment
There was a problem hiding this comment.
Code changes look reasonable.
kkysen
added a commit
that referenced
this pull request
Sep 29, 2025
merged (#1383) GitHub annoyingly does not re-run CI based on the result of merging a PR into `master`, just that PR itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leaves alone
stditems that could bealloc, likestd::vec::from_elemorstd::ffi::CString::new(needs a newerrustc1.63), but it should address most cases.