transpile: support anonymous struct/union/enums within structs and unions#1361
Merged
kkysen merged 2 commits intoimmunant:masterfrom Sep 28, 2025
Merged
transpile: support anonymous struct/union/enums within structs and unions#1361kkysen merged 2 commits intoimmunant:masterfrom
struct/union/enums within structs and unions#1361kkysen merged 2 commits intoimmunant:masterfrom
Conversation
kkysen
approved these changes
Sep 12, 2025
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
Thanks for fixing this, too! I left some comments/suggestions about naming and other stuff, but the logic LGTM.
kkysen
changed the title
struct/union/enum) within other record types
kkysen
changed the title
struct/union/enum) within other record typesstruct/union/enum within structs and unions
kkysen
changed the title
struct/union/enum within structs and unionsstruct/union/enums within structs and unions
bungcip
force-pushed
the
anon-enum
branch
2 times, most recently
from
8bd2164 to
4f4c86f
Compare
… `union`) to `visit_record_children`
… TagStructDecl/TagUnionDecl node RecordDecl can have anonymous struct or enum as children so we must collect them so they can have parent in TypedAstContext
Contributor
Author
|
hi @kkysen, sorry for late response. can you review this PR again? |
kkysen
added a commit
that referenced
this pull request
Sep 29, 2025
merged (#1383) GitHub annoyingly does not re-run CI based on the result of merging a PR into `master`, just that PR itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecordDeclcan have anonymous struct or enum as children so we must collect them so they can have parent inTypedAstContext.