correctly construct _ as Ident rather than Punctuation#1202
Merged
kkysen merged 1 commit intoimmunant:masterfrom Feb 24, 2025
Merged
correctly construct _ as Ident rather than Punctuation#1202kkysen merged 1 commit intoimmunant:masterfrom
kkysen merged 1 commit intoimmunant:masterfrom
Conversation
Contributor
Author
|
Note that I did not put much thought into the span that is put in. Looks natural to use this one, could also have used |
fw-immunant
approved these changes
Feb 21, 2025
Contributor
fw-immunant
left a comment
fw-immunant
left a comment
There was a problem hiding this comment.
LGTM. I don't think getting the span perfectly minimal is a big deal here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes another bug like #1197:
_is no puctuation -- another case of dtolnay/proc-macro2#475, fall-out of dtolnay/proc-macro2#470.Testing
This enables building RIOT sources again without
--locked. I'm not entirely sure, but I think the offending assembly waswhich gets turned into
where the
_is the identifier (formerly punctuation) which c2rust trips over.