Merged
Conversation
this should allow using newer versions of proc_macro2
kkysen
approved these changes
Jan 27, 2025
Contributor
kkysen
left a comment
There was a problem hiding this comment.
LGTM.
@kornelski, does this fix the issue? You can test it by checking out this branch and then rm Cargo.lock and cargo +stable install --path c2rust (since cargo install --git doesn't allow --bin).
Contributor
Author
This appears to fix the issue locally; a build with |
This was referenced Feb 21, 2025
Open
kkysen
added a commit
that referenced
this pull request
Feb 24, 2025
This fixes another bug like #1197: `_` is no puctuation -- another case of dtolnay/proc-macro2#475, fall-out of dtolnay/proc-macro2#470. ## Testing This enables building RIOT sources again without `--locked`. I'm not entirely sure, but I think the offending assembly was ```c __ASM ("rev %0, %1" : __CMSIS_GCC_OUT_REG (result) : __CMSIS_GCC_USE_REG (value) ); ``` which gets turned into ```rust asm!( "rev {0}, {1}", lateout(reg) result, inlateout(reg) value => _, options(preserves_flags, pure, readonly) ); ``` where the `_` is the identifier (formerly punctuation) which c2rust trips over.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unsupported proc macro punctuation character '('#1186.