Create generic-hand-select-grasp.json#185
Merged
Manishearth merged 5 commits intoimmersive-web:masterfrom Nov 13, 2020
Merged
Conversation
Tabs to spaces
Removed overlapping squeeze prefix
…lect-overlapping-squeeze.json Name change to match overlapping squeeze
fordacious
changed the title
…eric-hand-select-grasp.json overlapping-squeeze -> grasp
fordacious
changed the title
Contributor
|
So do y'all intend to trigger squeeze events when this profile is being used, or will this just be signalled as a toggling of the "grasp" button? Because if you trigger squeeze events that overlap with select, you're liable to have lots of bugs on content that is written for devices with independent select/squeeze events (see immersive-web/webxr#997) |
fordacious
changed the title
Contributor
Author
|
@Manishearth the idea for this one is to NOT trigger squeeze events. I renamed squeeze to grasp in this case to disambiguate that a bit. I'm not 100% on what the naming should be though so I think this is worthy to discuss. |
Contributor
|
Ah, that works great then. I'm r+ on this, and we may want to mention this profile in the hand input repo. |
Contributor
Author
|
@toji How's it looking? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing the generic-hand-select-grasp input profile. This input profile is appropriate for hand tracked systems which expose select and squeeze gestures in which the squeeze gesture may overlap with the select gesture and does not fire squeeze events.