Merged
Conversation
cabanier
reviewed
Nov 16, 2020
index.bs
Outdated
|
|
||
| [=Physical hand input sources=] MUST include the [=XRInputSource/input profile name=] of "generic-hand-select" in their {{XRInputSource/profiles}}. | ||
|
|
||
| For many [=physical hand input sources=], there can be overlap between the gestures used for the [=primary action=] and the squeeze action. Since content may assume that these are independent events, user agents MAY, instead of surfacing the squeeze action as the [=primary squeeze action=], surface it as an additional "grasp button", using an input profile derived from the "generic-hand-select-grasp" profile. |
Member
There was a problem hiding this comment.
This needs rephrasing or an explanatory note because context is missing.
Contributor
Author
There was a problem hiding this comment.
Added an example
Manishearth
force-pushed
the
grasp-profile
branch
from
be2ca85 to
5f10c22
Compare
Member
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From immersive-web/webxr-input-profiles#185
r? @cabanier @fordacious
Preview | Diff